mtd: rawnand: meson: only initialize the RB completion once
authorMartin Blumenstingl <martin.blumenstingl@googlemail.com>
Thu, 11 Apr 2019 22:00:56 +0000 (00:00 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Thu, 18 Apr 2019 06:54:07 +0000 (08:54 +0200)
commit39e01956e2f70ff9f0e97db1a69c9847aa1d5d8b
treedcdaac6911fca468ab2ae83eaae41ef0da4da4c0
parentc96ffedf8a2f91c9124012ec4eef42a3da01d08b
mtd: rawnand: meson: only initialize the RB completion once

Documentation/scheduler/completion.txt states:
  Calling init_completion() on the same completion object twice is
  most likely a bug as it re-initializes the queue to an empty queue and
  enqueued tasks could get "lost" - use reinit_completion() in that case,
  but be aware of other races.

Initialize nfc->completion in meson_nfc_probe using init_completion and
change the call in meson_nfc_queue_rb to reinit_completion so the logic
matches what the documentation suggests.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Tested-by:Liang Yang <liang.yang@amlogic.com>
Acked-by: Liang Yang <liang.yang@amlogic.com>
Tested-by:Liang Yang <liang.yang@amlogic.com>
Acked-by: Liang Yang <liang.yang@amlogic.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/raw/meson_nand.c