staging: rtl8723bs: refactor rtw_macaddr_cfg()
authorMichael Straube <straube.linux@gmail.com>
Wed, 27 Jun 2018 17:36:47 +0000 (19:36 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Jun 2018 13:46:01 +0000 (22:46 +0900)
commit375a2bd2758395ecf8aed01ea264953afede6a4f
tree3747a78534f847b709e318688560f4fde947a5a1
parent05ccc7061a3b2f11ac0a6c4d9528b4ca62acc139
staging: rtl8723bs: refactor rtw_macaddr_cfg()

Using is_broadcast_ether_addr() and is_zero_ether_addr() instead of
testing each byte of the mac[] array for 0xff and 0x00 shortens the
code and improves readability.

If np == NULL, of_get_property() returns NULL, hence the "np" check
is not needed.

Instead of a fixed default mac address use a random one to reduce the
likelihood of mac address collision.

Thanks to Joe Perches and Dan Carpenter.

Suggested-by: Joe Perches <joe@perches.com>
Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/core/rtw_ieee80211.c