sctp: do trace_sctp_probe after SACK validation and check
authorKevin Kou <qdkevin.kou@gmail.com>
Wed, 25 Dec 2019 08:27:25 +0000 (08:27 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 28 Dec 2019 00:34:51 +0000 (16:34 -0800)
commit356b23c073dd063427102329b296061855b912d9
treecff586943ef88f8f7fb02f60416d8cb748281631
parent0df952873636a6df4b7469a4eb4da1e477031e3a
sctp: do trace_sctp_probe after SACK validation and check

The function sctp_sf_eat_sack_6_2 now performs the Verification
Tag validation, Chunk length validation, Bogu check, and also
the detection of out-of-order SACK based on the RFC2960
Section 6.2 at the beginning, and finally performs the further
processing of SACK. The trace_sctp_probe now triggered before
the above necessary validation and check.

this patch is to do the trace_sctp_probe after the chunk sanity
tests, but keep doing trace if the SACK received is out of order,
for the out-of-order SACK is valuable to congestion control
debugging.

v1->v2:
 - keep doing SCTP trace if the SACK is out of order as Marcelo's
   suggestion.
v2->v3:
 - regenerate the patch as v2 generated on top of v1, and add
   'net-next' tag to the new one as Marcelo's comments.

Signed-off-by: Kevin Kou <qdkevin.kou@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/sm_statefuns.c