mwifex: free rx_cmd skb in suspended state
authorGanapathi Bhat <gbhat@marvell.com>
Tue, 21 Aug 2018 07:53:02 +0000 (13:23 +0530)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 31 Aug 2018 15:46:53 +0000 (18:46 +0300)
commit33a164fa8a4c91408e0b7738f754cb1a7827c5f2
treed7d47805dc079c3c4d6800f68197740dc79958dc
parent7bd4628c2f31c51254aa39628ecae521d00d0b90
mwifex: free rx_cmd skb in suspended state

USB suspend handler will kill the presubmitted rx_cmd URB. This
triggers a call to the corresponding URB complete handler, which
will free the rx_cmd skb, associated with rx_cmd URB. Due to a
possible race betwen suspend handler and main thread, depicted in
'commit bfcacac6c84b ("mwifiex: do no submit URB in suspended
state")', it is possible that the rx_cmd skb will fail to get
freed. This causes a memory leak, since the resume handler will
always allocate a new rx_cmd skb.

To fix this, free the rx_cmd skb in mwifiex_usb_submit_rx_urb, if
the device is in suspended state.

Signed-off-by: Vidya Dharmaraju <vidyad@marvell.com>
Signed-off-by: Cathy Luo <cluo@marvell.com>
Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/marvell/mwifiex/usb.c