x86/speculation: Prevent deadlock on ssb_state::lock
authorThomas Gleixner <tglx@linutronix.de>
Sun, 14 Apr 2019 17:51:06 +0000 (19:51 +0200)
committerThomas Gleixner <tglx@linutronix.de>
Sun, 14 Apr 2019 21:05:52 +0000 (23:05 +0200)
commit2f5fb19341883bb6e37da351bc3700489d8506a7
tree7773a842ba67a344b4b4da5aff530404f140571d
parent40fba00ffa431c8597ca785ea1cfa4d9f6503390
x86/speculation: Prevent deadlock on ssb_state::lock

Mikhail reported a lockdep splat related to the AMD specific ssb_state
lock:

  CPU0                       CPU1
  lock(&st->lock);
                             local_irq_disable();
                             lock(&(&sighand->siglock)->rlock);
                             lock(&st->lock);
  <Interrupt>
     lock(&(&sighand->siglock)->rlock);

  *** DEADLOCK ***

The connection between sighand->siglock and st->lock comes through seccomp,
which takes st->lock while holding sighand->siglock.

Make sure interrupts are disabled when __speculation_ctrl_update() is
invoked via prctl() -> speculation_ctrl_update(). Add a lockdep assert to
catch future offenders.

Fixes: 1f50ddb4f418 ("x86/speculation: Handle HT correctly on AMD")
Reported-by: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
Cc: Thomas Lendacky <thomas.lendacky@amd.com>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/alpine.DEB.2.21.1904141948200.4917@nanos.tec.linutronix.de
arch/x86/kernel/process.c