projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: bfdaa39) | patch
Staging: silicom: fix dangerous if condition in bpctl_mod.c
authorNeil Armstrong <superna9999@gmail.com>
Tue, 1 Apr 2014 13:03:44 +0000 (15:03 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 25 Apr 2014 22:33:35 +0000 (15:33 -0700)
commit2f4285d17d3a5ae42e2811005dbcd4818d5d6ebe
tree9e368f937d297b11bdb0ed31ede4a762ba9f17batree | snapshot
parentbfdaa39f42e6f7b364f3c499af9a67b1d8186c8bcommit | diff
Staging: silicom: fix dangerous if condition in bpctl_mod.c

checkpatch script returns the following warning:
ERROR: do not use assignment in if condition
+                       if (((dev_num = get_dev_idx(dev->ifindex)) ==
            -1) |

This patch fixes the if condition by splitting it.

Signed-off-by: Neil Armstrong <superna9999@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/silicom/bpctl_mod.c diff | blob | history
John Crispins staging tree