ALSA: fireworks: fix wrong reference count for stream functionality at error path...
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Sun, 7 Jul 2019 05:20:07 +0000 (14:20 +0900)
committerTakashi Iwai <tiwai@suse.de>
Sun, 7 Jul 2019 09:19:56 +0000 (11:19 +0200)
commit2e9f17e34eb7b728d4cd9ec474c3c5a9a6685298
tree826895ae1ecfcd14cbd0c79345f1a7a0a0558acd
parent097f8ba3873dcbd2f55c627ed2fe0b13845e53cd
ALSA: fireworks: fix wrong reference count for stream functionality at error path of rawmidi interface

In IEC 61883-6, several types of sampling data can be multiplexed into
payload of common isochronous packet (CIP). For typical audio and music
units, PCM samples and MIDI messages are multiplexed into one packet
streaming.

ALSA fireworks driver allows applications of rawmidi interface to start
packet streaming for transmission of MIDI messages. However at error
path, the reference count of stream functionality is not operated
correctly. This can brings a bug that packet streaming is not stopped
when all referrers release the count.

This commit fixes the bug.

Fixes: 3d7250667ea9 ("ALSA: fireworks: configure sampling transfer frequency in pcm.hw_params callback")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/fireworks/fireworks_midi.c