projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 3399a3f) | patch
block: fix bogus EFAULT error from SG_IO ioctl
authorPaolo Bonzini <pbonzini@redhat.com>
Fri, 26 Jun 2015 09:44:46 +0000 (11:44 +0200)
committerJens Axboe <axboe@fb.com>
Sat, 27 Jun 2015 17:43:34 +0000 (11:43 -0600)
commit2c4cffe85170a001c1d092681c86aa1128295221
treec79d5bc1a94c2b6886826e170decad8f55cd6c2atree | snapshot
parent3399a3f7464a624db1b365dbce0fef0ef4636c05commit | diff
block: fix bogus EFAULT error from SG_IO ioctl

Whenever blk_fill_sghdr_rq fails, its errno code is ignored and changed to
EFAULT.  This can cause very confusing errors:

  $ sg_persist -k /dev/sda
  persistent reservation in: pass through os error: Bad address

The fix is trivial, just propagate the return value from
blk_fill_sghdr_rq.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Jens Axboe <axboe@fb.com>
block/scsi_ioctl.c diff | blob | history
John Crispins staging tree