arm64: untag user pointers in access_ok and __uaccess_mask_ptr
authorAndrey Konovalov <andreyknvl@google.com>
Tue, 23 Jul 2019 17:58:38 +0000 (19:58 +0200)
committerWill Deacon <will@kernel.org>
Tue, 6 Aug 2019 17:08:25 +0000 (18:08 +0100)
commit2b835e24b5c6f9c633ff51973581ee7ca7b3e8ec
treef3de91fbb738cccbdcfdda3754765cbb3bd24e0e
parente21a712a9685488f5ce80495b37b9fdbe96c230d
arm64: untag user pointers in access_ok and __uaccess_mask_ptr

This patch is a part of a series that extends kernel ABI to allow to pass
tagged user pointers (with the top byte set to something else other than
0x00) as syscall arguments.

copy_from_user (and a few other similar functions) are used to copy data
from user memory into the kernel memory or vice versa. Since a user can
provided a tagged pointer to one of the syscalls that use copy_from_user,
we need to correctly handle such pointers.

Do this by untagging user pointers in access_ok and in __uaccess_mask_ptr,
before performing access validity checks.

Note, that this patch only temporarily untags the pointers to perform the
checks, but then passes them as is into the kernel internals.

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
[will: Add __force to casting in untagged_addr() to kill sparse warning]
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/include/asm/memory.h
arch/arm64/include/asm/uaccess.h