libbpf: Fix passing uninitialized bytes to setsockopt
authorIlya Maximets <i.maximets@ovn.org>
Wed, 9 Oct 2019 16:49:29 +0000 (18:49 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 9 Oct 2019 22:45:37 +0000 (15:45 -0700)
commit25bfef430e960e695403b5d9c8dcc11b9f5d62be
tree8b4349590cbbdc4f2c6444d6b92c5437fc8b6b07
parentf1177102454e1832b9814051f2b071a8285581ea
libbpf: Fix passing uninitialized bytes to setsockopt

'struct xdp_umem_reg' has 4 bytes of padding at the end that makes
valgrind complain about passing uninitialized stack memory to the
syscall:

  Syscall param socketcall.setsockopt() points to uninitialised byte(s)
    at 0x4E7AB7E: setsockopt (in /usr/lib64/libc-2.29.so)
    by 0x4BDE035: xsk_umem__create@@LIBBPF_0.0.4 (xsk.c:172)
  Uninitialised value was created by a stack allocation
    at 0x4BDDEBA: xsk_umem__create@@LIBBPF_0.0.4 (xsk.c:140)

Padding bytes appeared after introducing of a new 'flags' field.
memset() is required to clear them.

Fixes: 10d30e301732 ("libbpf: add flags to umem config")
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/20191009164929.17242-1-i.maximets@ovn.org
tools/lib/bpf/xsk.c