e1000e: Don't return uninitialized stats
authorBenjamin Poirier <bpoirier@suse.com>
Wed, 17 May 2017 20:24:13 +0000 (16:24 -0400)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Tue, 6 Jun 2017 08:05:13 +0000 (01:05 -0700)
commit24ad2a9209a0bf1ec37fac25a011c98551865abb
tree276930cbdf2187fbfb9779871c3ac6b651d66fe3
parent81e3f64a9b2d837717a58606d9f22420a47fdf68
e1000e: Don't return uninitialized stats

Some statistics passed to ethtool are garbage because e1000e_get_stats64()
doesn't write them, for example: tx_heartbeat_errors. This leaks kernel
memory to userspace and confuses users.

Do like ixgbe and use dev_get_stats() which first zeroes out
rtnl_link_stats64.

Fixes: 5944701df90d ("net: remove useless memset's in drivers get_stats64")
Reported-by: Stefan Priebe <s.priebe@profihost.ag>
Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/e1000e/ethtool.c