ALSA: Xonar, CS43xx: Don't overrun static array
authorJesper Juhl <jj@chaosbits.net>
Thu, 20 Jan 2011 21:37:43 +0000 (22:37 +0100)
committerTakashi Iwai <tiwai@suse.de>
Sat, 22 Jan 2011 16:24:30 +0000 (17:24 +0100)
commit233d84c46c2253d13e10b42d88c14748fbb67a98
treef1d0fed8209eaf4bf205440454db92f86d066349
parent842a2097007b8a01a71a701300e970502a54bbb2
ALSA: Xonar, CS43xx: Don't overrun static array

'cs4398_regs' in 'struct xonar_cs43xx' is an array of 'u8' with a size of
8. So, this code in sound/pci/oxygen/xonar_cs43xx.c::dump_d1_registers()

     for (i = 2; i <= 8; ++i)
   snd_iprintf(buffer, " %02x", data->cs4398_regs[i]);

will overrun the array when 'i == 8'.

I guess that what's needed to fix it is the trivial patch below, but I
must admit that I have no idea about this code, so I may very well be
wrong. Additionally, I have no way to actually test this, so all I know is
that the below compiles. Someone who actually knows this code should take
a look before anything is comitted - consider the below (not much more
than) a bug report.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Clemens Ladisch <clemens@ladisch.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/oxygen/xonar_cs43xx.c