perf/x86: Simplify x86_pmu.get_constraints() interface
authorPeter Zijlstra <peterz@infradead.org>
Thu, 14 Mar 2019 08:57:57 +0000 (09:57 +0100)
committerIngo Molnar <mingo@kernel.org>
Wed, 3 Apr 2019 07:25:30 +0000 (09:25 +0200)
commit21d65555cd878c8d6ff2b2902e6c16b2ca73f33d
tree0efdf589f5533234dde021ec47d5f959cfa9d2a5
parent1a81542abfdae21716a1a32ea8472de7a271dde6
perf/x86: Simplify x86_pmu.get_constraints() interface

There is a special case for validate_events() where we'll call
x86_pmu.get_constraints(.idx=-1). It's purpose, up until recent, seems
to be to avoid taking a previous constraint from
cpuc->event_constraint[] in intel_get_event_constraints().

(I could not find any other get_event_constraints() implementation
using @idx)

However, since that cpuc is freshly allocated, that array will in fact
be initialized with NULL pointers, achieving the very same effect.

Therefore remove this exception.

Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Stephane Eranian <eranian@google.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vince Weaver <vincent.weaver@maine.edu>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/events/core.c
arch/x86/events/intel/core.c