drm/amd/display: Fix BUG_ON during CRTC atomic check update
authorLeo (Sunpeng) Li <sunpeng.li@amd.com>
Tue, 29 May 2018 13:51:51 +0000 (09:51 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 29 May 2018 19:22:28 +0000 (14:22 -0500)
commit20fa2ff0441eabc8e6263b428191228d9599ea9d
treebded0b5c54d474fea6f18cfc1e687ebe49ab459c
parent72777fe79768ec30ac2163d26de68a89edc9849f
drm/amd/display: Fix BUG_ON during CRTC atomic check update

For cases where the CRTC is inactive (DPMS off), where a modeset is not
required, yet the CRTC is still in the atomic state, we should not
attempt to update anything on it.

Previously, we were relying on the modereset_required() helper to check
the above condition. However, the function returns false immediately if
a modeset is not required, ignoring the CRTC's enable/active state
flags. The correct way to filter is by looking at these flags instead.

Fixes: e277adc5a06c "drm/amd/display: Hookup color management functions"
Bugzilla: https://bugs.freedesktop.org/106194

Signed-off-by: Leo (Sunpeng) Li <sunpeng.li@amd.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Tested-by: Michel Dänzer <michel.daenzer@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c