watchdog: pic32-wdt: Convert to use device managed functions and other improvements
authorGuenter Roeck <linux@roeck-us.net>
Wed, 10 Apr 2019 16:27:57 +0000 (09:27 -0700)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Sun, 5 May 2019 19:02:36 +0000 (21:02 +0200)
commit1f22b8ca6b26e47ebbd5d0c9991207fe94c4b8db
tree5db0e1ded02dcd45660c39342a547f8d4f206756
parenta02b3d7cde3230f6a6c4c42a556b49411d4729a7
watchdog: pic32-wdt: Convert to use device managed functions and other improvements

Use device managed functions to simplify error handling, reduce
source code size, improve readability, and reduce the likelyhood of bugs.
Other improvements as listed below.

The conversion was done automatically with coccinelle using the
following semantic patches. The semantic patches and the scripts
used to generate this commit log are available at
https://github.com/groeck/coccinelle-patches

- Drop assignments to otherwise unused variables
- Drop empty remove function
- Use devm_add_action_or_reset() for calls to clk_disable_unprepare
- Introduce local variable 'struct device *dev' and use it instead of
  dereferencing it repeatedly
- Use devm_watchdog_register_driver() to register watchdog device

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/pic32-wdt.c