Staging: meilhaus: convert nested spin_lock_irqsave to spin_lock
authorJulia Lawall <julia@diku.dk>
Sat, 18 Jul 2009 15:25:30 +0000 (17:25 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 15 Sep 2009 19:02:05 +0000 (12:02 -0700)
commit1dd7def0b5d7d0464991640687fc85c143b3c850
treedc1901322d98fbab555b06c39f7ccf4eb008dccf
parentc60adf37eb9cbb244025a0d02ba41bc7931bc674
Staging: meilhaus: convert nested spin_lock_irqsave to spin_lock

If spin_lock_irqsave is called twice in a row with the same second
argument, the interrupt state at the point of the second call overwrites
the value saved by the first call.  Indeed, the second call does not need
to save the interrupt state, so it is changed to a simple spin_lock.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression lock1,lock2;
expression flags;
@@

*spin_lock_irqsave(lock1,flags)
... when != flags
*spin_lock_irqsave(lock2,flags)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: David Kiliani <mail@davidkiliani.de>
Cc: Meilhaus Support <support@meilhaus.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/meilhaus/me4600_ai.c