ieee802154: fix faulty check in set_phy_params api
authorPhoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
Tue, 18 Feb 2014 13:39:27 +0000 (14:39 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 18 Feb 2014 23:11:05 +0000 (18:11 -0500)
commit1c8272bd18cf284de5cb43fb6b0e0457041a17b2
tree80b2860c1058e8279fa67c6145788af9cd86b8a7
parent9e5f040d0f0caf84884174abd71be1edde2b88dc
ieee802154: fix faulty check in set_phy_params api

phy_set_csma_params has a redundant (and impossible) check for
"retries", found by smatch. The check was supposed to be for
frame_retries, but wasn't moved during development when
phy_set_frame_retries was introduced. Also, maxBE >= 3 as required by
the standard is not enforced.

Remove the redundant check, assure max_be >= 3 and check -1 <=
frame_retries <= 7 in the correct function.

Signed-off-by: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ieee802154/nl-phy.c