target: Fix QUEUE_FULL + SCSI task attribute handling
authorNicholas Bellinger <nab@linux-iscsi.org>
Fri, 22 Sep 2017 23:48:28 +0000 (16:48 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Wed, 8 Nov 2017 03:41:37 +0000 (19:41 -0800)
commit1c79df1f349fb6050016cea4ef1dfbc3853a5685
tree1dd17d3dd171b4706c96c40b7967181196867d36
parent17c45b90061a76fceadffbce8d85a9107a05a918
target: Fix QUEUE_FULL + SCSI task attribute handling

This patch fixes a bug during QUEUE_FULL where transport_complete_qf()
calls transport_complete_task_attr() after it's already been invoked
by target_complete_ok_work() or transport_generic_request_failure()
during initial completion, preceeding QUEUE_FULL.

This will result in se_device->simple_cmds, se_device->dev_cur_ordered_id
and/or se_device->dev_ordered_sync being updated multiple times for
a single se_cmd.

To address this bug, clear SCF_TASK_ATTR_SET after the first call
to transport_complete_task_attr(), and avoid updating SCSI task
attribute related counters for any subsequent calls.

Also, when a se_cmd is deferred due to ordered tags and executed
via target_restart_delayed_cmds(), set CMD_T_SENT before execution
matching what target_execute_cmd() does.

Cc: Michael Cyr <mikecyr@linux.vnet.ibm.com>
Cc: Bryant G. Ly <bryantly@linux.vnet.ibm.com>
Cc: Mike Christie <mchristi@redhat.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: stable@vger.kernel.org # 4.1+
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_transport.c