ipv4: fix memory leaks in udp_sendmsg, ping_v4_sendmsg
authorAndrey Ignatov <rdna@fb.com>
Thu, 10 May 2018 17:59:34 +0000 (10:59 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 11 May 2018 16:00:58 +0000 (12:00 -0400)
commit1b97013bfb11d66f041de691de6f0fec748ce016
treef68daaa874de1b25206aaf0a81c04c455b5a8563
parent8ccc113172e4c1ebef45c2433f3c32ed6ae1b9c9
ipv4: fix memory leaks in udp_sendmsg, ping_v4_sendmsg

Fix more memory leaks in ip_cmsg_send() callers. Part of them were fixed
earlier in 919483096bfe.

* udp_sendmsg one was there since the beginning when linux sources were
  first added to git;
* ping_v4_sendmsg one was copy/pasted in c319b4d76b9e.

Whenever return happens in udp_sendmsg() or ping_v4_sendmsg() IP options
have to be freed if they were allocated previously.

Add label so that future callers (if any) can use it instead of kfree()
before return that is easy to forget.

Fixes: c319b4d76b9e (net: ipv4: add IPPROTO_ICMP socket kind)
Signed-off-by: Andrey Ignatov <rdna@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ping.c
net/ipv4/udp.c