drm/i915: Fix kzalloc() smatch warnings in get_initial_plane_config()
authorDamien Lespiau <damien.lespiau@intel.com>
Wed, 21 Jan 2015 13:50:54 +0000 (13:50 +0000)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Tue, 27 Jan 2015 08:51:07 +0000 (09:51 +0100)
commit1b842c89bd8eb0e9619e1aba071c9a5529b7a179
tree64ecb4ae0ba844eb9d9c8df61542ed54cf9c1753
parent0f71979ab7fbd0c71c41c2798de3d33937915434
drm/i915: Fix kzalloc() smatch warnings in get_initial_plane_config()

Smatch doesn't like:

  struct drm_framebuffer *fb;
  fb = kzalloc(sizeof(struct intel_framebuffer), GFP_KERNEL);

and warns with:

  warn: struct type mismatch 'drm_framebuffer vs intel_framebuffer'

This implicit cast was correct as struct intel_framebuffer has struct
drm_framebuffer as its first member, but in case someone want to reorder
the fields for some reason, it's slightly safer to access the underlying
drm_framebuffer through intel_fb->base.

Also, having fewer static analysis warnings is a worthy goal.

Cc: kbuild@01.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/intel_display.c