drm/vkms: Remove useless call to drm_connector_register/unregister()
authorRodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Fri, 15 Mar 2019 16:11:42 +0000 (13:11 -0300)
committerRodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Thu, 6 Jun 2019 23:33:28 +0000 (20:33 -0300)
commit1ae752bf390c84250b702bd7d983c94d6eda42e2
tree3927bf02b779878e3fd63c54cd5079508653fee8
parent5e2f97a93f7043f2a95caebceea1ac5f9adf8ff9
drm/vkms: Remove useless call to drm_connector_register/unregister()

The function vkms_output_init() is invoked during the module
initialization, and it handles the creation/configuration of the vkms
essential elements (e.g., connectors, encoder, etc). Among the
initializations, this function tries to initialize a connector and
register it by calling drm_connector_register(). However, inside the
drm_connector_register(), at the beginning of this function there is the
following validation:

 if (!connector->dev->registered)
   return 0;

In this sense, invoke drm_connector_register() after initializing the
connector has no effect because the register field is false. The
connector register happens when drm_dev_register() is invoked; the same
issue exists with drm_connector_unregister(). Therefore, this commit
removes the unnecessary call to drm_connector_register() and
drm_connector_unregister().

Changes since v2:
* Remove unnecessary call to drm_connector_unregister()
* Remove unused label

Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Reviewed-by: Daniel Vetter <daniel@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20190315161142.23gfu32lueyqrmyq@smtp.gmail.com
drivers/gpu/drm/vkms/vkms_output.c