net: allow netif_carrier to be called safely from IRQ
authorstephen hemminger <shemminger@vyatta.com>
Fri, 22 Jul 2011 12:53:56 +0000 (12:53 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 23 Jul 2011 00:01:14 +0000 (17:01 -0700)
commit1821f7cd65ad9ea56580b830ac79bf4c4fef59cb
treecc483748bed6b3748ccece6c26d1c8a334bd0ba4
parent758ccc34389811c84382a79e198e4b6250ae0478
net: allow netif_carrier to be called safely from IRQ

As reported by Ben Greer and Froncois Romieu. The code path in
the netif_carrier code leads it to try and disable
a late workqueue to reenable it immediately
netif_carrier_on
-> linkwatch_fire_event
   -> linkwatch_schedule_work
      -> cancel_delayed_work
         -> del_timer_sync

If __cancel_delayed_work is used instead then there is no
problem of waiting for running linkwatch_event.

There is a race between linkwatch_event running re-scheduling
but it is harmless to schedule an extra scan of the linkwatch queue.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/link_watch.c