USB: fix linked-list corruption in rh_call_control()
authorAlan Stern <stern@rowland.harvard.edu>
Fri, 24 Mar 2017 17:38:28 +0000 (13:38 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Mar 2017 07:24:13 +0000 (09:24 +0200)
commit1633682053a7ee8058e10c76722b9b28e97fb73f
tree7d62e7f9b7cb9f51e15063a6a51cf20642237f91
parentc02ed2e75ef4c74e41e421acb4ef1494671585e8
USB: fix linked-list corruption in rh_call_control()

Using KASAN, Dmitry found a bug in the rh_call_control() routine: If
buffer allocation fails, the routine returns immediately without
unlinking its URB from the control endpoint, eventually leading to
linked-list corruption.

This patch fixes the problem by jumping to the end of the routine
(where the URB is unlinked) when an allocation failure occurs.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-and-tested-by: Dmitry Vyukov <dvyukov@google.com>
CC: <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/hcd.c