projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 5d32407) | patch
mac80211_hwsim: Fix a possible sleep-in-atomic bug in hwsim_get_radio_nl
authorJia-Ju Bai <baijiaju1990@163.com>
Tue, 12 Dec 2017 09:26:36 +0000 (17:26 +0800)
committerJohannes Berg <johannes.berg@intel.com>
Tue, 19 Dec 2017 08:14:06 +0000 (09:14 +0100)
commit162bd5e5fd921785077b5862d8f2ffabe2fe11e5
tree26cc8e6a69b56fce2c1eae9b634c08c8253216abtree | snapshot
parent5d32407396b0433f9b738fcfcb9599bcba7379aecommit | diff
mac80211_hwsim: Fix a possible sleep-in-atomic bug in hwsim_get_radio_nl

The driver may sleep under a spinlock.
The function call path is:
hwsim_get_radio_nl (acquire the spinlock)
  nlmsg_new(GFP_KERNEL) --> may sleep

To fix it, GFP_KERNEL is replaced with GFP_ATOMIC.

This bug is found by my static analysis tool(DSAC) and checked by my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/mac80211_hwsim.c diff | blob | history
John Crispins staging tree