projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: daeafdc) | patch
macb: Remove inappropriate spinlocks around mii calls
authorHaavard Skinnemoen <hskinnemoen@atmel.com>
Fri, 16 Feb 2007 14:59:06 +0000 (15:59 +0100)
committerJeff Garzik <jeff@garzik.org>
Sat, 17 Feb 2007 20:30:48 +0000 (15:30 -0500)
commit140e807dd7d6aa68e601f50a10abd5351e06126f
tree4481f795dffd8db8fe1723200614018d06ac2815tree | snapshot
parentdaeafdc360f91d286490105e67b13f094381e23fcommit | diff
macb: Remove inappropriate spinlocks around mii calls

Remove spin_lock_irqsave() around mii_ethtool_gset, mii_ethtool_sset
and generic_mii_ioctl. These are unnecessary and harmful because
the mii calls may call back into the mdio functions, which may sleep.

Pointed out by David Brownell.

Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/macb.c diff | blob | history
John Crispins staging tree