SCSI: fix crashes in sd and sr runtime PM
authorAlan Stern <stern@rowland.harvard.edu>
Wed, 20 Jan 2016 16:26:01 +0000 (11:26 -0500)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Wed, 27 Jan 2016 01:24:16 +0000 (17:24 -0800)
commit13b4389143413a1f18127c07f72c74cad5b563e8
tree8b18c39922c06b2a569e669adaacbf503500af00
parent92e963f50fc74041b5e9e744c330dca48e04f08d
SCSI: fix crashes in sd and sr runtime PM

Runtime suspend during driver probe and removal can cause problems.
The driver's runtime_suspend or runtime_resume callbacks may invoked
before the driver has finished binding to the device or after the
driver has unbound from the device.

This problem shows up with the sd and sr drivers, and can cause disk
or CD/DVD drives to become unusable as a result.  The fix is simple.
The drivers store a pointer to the scsi_disk or scsi_cd structure as
their private device data when probing is finished, so we simply have
to be sure to clear the private data during removal and test it during
runtime suspend/resume.

This fixes <https://bugs.debian.org/801925>.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-by: Paul Menzel <paul.menzel@giantmonkey.de>
Reported-by: Erich Schubert <erich@debian.org>
Reported-by: Alexandre Rossi <alexandre.rossi@gmail.com>
Tested-by: Paul Menzel <paul.menzel@giantmonkey.de>
Tested-by: Erich Schubert <erich@debian.org>
CC: <stable@vger.kernel.org>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/sd.c
drivers/scsi/sr.c