drm/i915/breadcrumbs: Ignore unsubmitted signalers
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 13 Feb 2018 09:01:54 +0000 (09:01 +0000)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Wed, 14 Feb 2018 00:55:45 +0000 (16:55 -0800)
commit117172c8f9d40ba1de8cb35c6e614422faa03330
treec1bcd9e2bf33b40e9eb7934d7a5347eda8cea841
parent7292b9e6586534fb43e4316ad8b508bf3d1212f7
drm/i915/breadcrumbs: Ignore unsubmitted signalers

When a request is preempted, it is unsubmitted from the HW queue and
removed from the active list of breadcrumbs. In the process, this
however triggers the signaler and it may see the clear rbtree with the
old, and still valid, seqno, or it may match the cleared seqno with the
now zero rq->global_seqno. This confuses the signaler into action and
signaling the fence.

Fixes: d6a2289d9d6b ("drm/i915: Remove the preempted request from the execution queue")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: <stable@vger.kernel.org> # v4.12+
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180206094633.30181-1-chris@chris-wilson.co.uk
(cherry picked from commit fd10e2ce9905030d922e179a8047a4d50daffd8e)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180213090154.17373-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/intel_breadcrumbs.c