ALSA: pcm: Fix double hw_free calls
authorTakashi Iwai <tiwai@suse.de>
Thu, 13 Feb 2020 06:03:49 +0000 (07:03 +0100)
committerTakashi Iwai <tiwai@suse.de>
Thu, 13 Feb 2020 15:30:22 +0000 (16:30 +0100)
commit0fbb027b44e79700da80e4b8bd1c1914d4796af6
tree218dfdd93e79af7f7df2007ab99cf7106c6d6a3f
parent9f35a31283775e6f6af73fb2c95c686a4c0acac7
ALSA: pcm: Fix double hw_free calls

The commit 66f2d19f8116 ("ALSA: pcm: Fix memory leak at closing a
stream without hw_free") tried to fix the regression wrt the missing
hw_free call at closing without SNDRV_PCM_IOCTL_HW_FREE ioctl.
However, the code change dropped mistakenly the state check, resulting
in calling hw_free twice when SNDRV_PCM_IOCTL_HW_FRE got called
beforehand.  For most drivers, this is almost harmless, but the
drivers like SOF show another regression now.

This patch adds the state condition check before calling do_hw_free()
at releasing the stream for avoiding the double hw_free calls.

Fixes: 66f2d19f8116 ("ALSA: pcm: Fix memory leak at closing a stream without hw_free")
Reported-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tested-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/s5hd0ajyprg.wl-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/pcm_native.c