bpf: Fix preempt_enable_no_resched() abuse
authorPeter Zijlstra <peterz@infradead.org>
Tue, 23 Apr 2019 19:55:59 +0000 (21:55 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Fri, 26 Apr 2019 00:20:06 +0000 (17:20 -0700)
commit0edd6b64d1939e9e9168ff27947995bb7751db5d
treebda2ebb26824837370940415fa1857bb29d28d06
parent6dd7f14080473b655c247863e61b7c34424f0c83
bpf: Fix preempt_enable_no_resched() abuse

Unless the very next line is schedule(), or implies it, one must not use
preempt_enable_no_resched(). It can cause a preemption to go missing and
thereby cause arbitrary delays, breaking the PREEMPT=y invariant.

Cc: Roman Gushchin <guro@fb.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
include/linux/bpf.h