ext4: fix type-widening bug in inode table readahead code
authorTheodore Ts'o <tytso@mit.edu>
Tue, 23 Apr 2013 12:59:35 +0000 (08:59 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Tue, 23 Apr 2013 12:59:35 +0000 (08:59 -0400)
commit0d606e2c9fccdd4e67febf1e2da500e1bfe9e045
tree9b908af21c968176149bbbf4016306fa50774055
parent3f8a6411fbada1fa482276591e037f3b1adcf55b
ext4: fix type-widening bug in inode table readahead code

Due to a missing cast, the high 32-bits of a 64-bit block number used
when calculating the readahead block for inode tables can get lost.
This means we can end up fetching the wrong blocks for readahead for
file systems > 16TB.

Linus found this when experimenting with an enhacement to the sparse
static code checker which checks for missing widening casts before
binary "not" operators.

Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/inode.c