projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 6e1d7a5) | patch
ALSA: oxfw: fix detect_loud_models() return value
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 12 Dec 2014 19:28:10 +0000 (22:28 +0300)
committerTakashi Iwai <tiwai@suse.de>
Sun, 14 Dec 2014 15:04:50 +0000 (16:04 +0100)
commit0d3aba30b755fe9ccaf390f0e71f6fb9fd55bd87
treed876b22571cf2dfa00d67a2a40af55e69888dfa2tree | snapshot
parent6e1d7a51392f06899bd7b693f28ac60fa1e00032commit | diff
ALSA: oxfw: fix detect_loud_models() return value

This code causes a static checker warning:

sound/firewire/oxfw/oxfw.c:46 detect_loud_models()
warn: signedness bug returning '(-2)'

The detect_loud_models() function should return false on falure, so that
we don't try to set up the loud code for hardware that doesn't support
it.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/oxfw/oxfw.c diff | blob | history
John Crispins staging tree