projects / openwrt / staging / blogic.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: c7d852e) | patch
fsl/fman_port: remove redundant check on port->rev_info.major
authorColin Ian King <colin.king@canonical.com>
Tue, 24 Apr 2018 11:39:45 +0000 (12:39 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 24 Apr 2018 20:00:37 +0000 (16:00 -0400)
commit080aaddae5b378ebb0f06d297bf05cf4ec5b47ac
treeaef5d6fe657e125ce86d6ea2b9b53f994c06febftree | snapshot
parentc7d852e301d834949e570920db808201bdc51a22commit | diff
fsl/fman_port: remove redundant check on port->rev_info.major

The check port->rev_info.major >= 6 is being performed twice, thus
the inner second check is always true and is redundant, hence it
can be removed. Detected by cppcheck.

drivers/net/ethernet/freescale/fman/fman_port.c:1394]: (warning)
Identical inner 'if' condition is always true.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/fman/fman_port.c diff | blob | history
John Crispins staging tree