md/raid1: fail run raid1 array when active disk less than one
authorYufen Yu <yuyufen@huawei.com>
Tue, 3 Sep 2019 13:12:41 +0000 (21:12 +0800)
committerSong Liu <songliubraving@fb.com>
Tue, 3 Sep 2019 21:52:03 +0000 (14:52 -0700)
commit07f1a6850c5d5a65c917c3165692b5179ac4cb6b
tree2da1c0e21745ab935f37b29994ac00e11e35548b
parent62f7b1989c02feed9274131b2fd5e990de4aba6f
md/raid1: fail run raid1 array when active disk less than one

When run test case:
  mdadm -CR /dev/md1 -l 1 -n 4 /dev/sd[a-d] --assume-clean --bitmap=internal
  mdadm -S /dev/md1
  mdadm -A /dev/md1 /dev/sd[b-c] --run --force

  mdadm --zero /dev/sda
  mdadm /dev/md1 -a /dev/sda

  echo offline > /sys/block/sdc/device/state
  echo offline > /sys/block/sdb/device/state
  sleep 5
  mdadm -S /dev/md1

  echo running > /sys/block/sdb/device/state
  echo running > /sys/block/sdc/device/state
  mdadm -A /dev/md1 /dev/sd[a-c] --run --force

mdadm run fail with kernel message as follow:
[  172.986064] md: kicking non-fresh sdb from array!
[  173.004210] md: kicking non-fresh sdc from array!
[  173.022383] md/raid1:md1: active with 0 out of 4 mirrors
[  173.022406] md1: failed to create bitmap (-5)

In fact, when active disk in raid1 array less than one, we
need to return fail in raid1_run().

Reviewed-by: NeilBrown <neilb@suse.de>
Signed-off-by: Yufen Yu <yuyufen@huawei.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
drivers/md/raid1.c