scsi: libsas: only clear phy->in_shutdown after shutdown event done
authorJason Yan <yanaijie@huawei.com>
Tue, 14 May 2019 02:42:38 +0000 (10:42 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 30 May 2019 02:08:19 +0000 (22:08 -0400)
commit04cf8b32bc6d3fbc640d5f62b3a14df207d3e1db
tree5050ab50efdb9b02c1e47ec2b45ea3a0fb99d1a7
parent12e750bc62044de096ab9a95201213fd912b9994
scsi: libsas: only clear phy->in_shutdown after shutdown event done

When the event queue is full of phy up and down events and reached the
threshold, we will queue a shutdown-event, and set phy->in_shutdown so that
we will not queue a shutdown-event again. But before the shutdown-event can
be executed, every phy-down event will clear
phy->in_shutdown and a new shutdown-event will be queued. The queue will
be full of these shutdown-events.

Fix this by only clear phy->in_shutdown in sas_phye_shutdown(), that is
after the first shutdown-event has been executed.

Fixes: f12486e06ae8 ("scsi: libsas: shut down the PHY if events reached the threshold")
Signed-off-by: Jason Yan <yanaijie@huawei.com>
CC: John Garry <john.garry@huawei.com>
CC: Johannes Thumshirn <jthumshirn@suse.de>
CC: Ewan Milne <emilne@redhat.com>
CC: Christoph Hellwig <hch@lst.de>
CC: Tomas Henzl <thenzl@redhat.com>
CC: Dan Williams <dan.j.williams@intel.com>
CC: Hannes Reinecke <hare@suse.com>
Reviewed-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/libsas/sas_phy.c