splice: fix racy pipe->buffers uses
authorEric Dumazet <edumazet@google.com>
Tue, 12 Jun 2012 13:24:40 +0000 (15:24 +0200)
committerJens Axboe <axboe@kernel.dk>
Wed, 13 Jun 2012 19:16:42 +0000 (21:16 +0200)
commit047fe3605235888f3ebcda0c728cb31937eadfe6
tree9c33ef4b076bd54f686afe924cee01e21c55f427
parent27e1f9d1cc87be4e53c6eb7158cafc21c4b85a14
splice: fix racy pipe->buffers uses

Dave Jones reported a kernel BUG at mm/slub.c:3474! triggered
by splice_shrink_spd() called from vmsplice_to_pipe()

commit 35f3d14dbbc5 (pipe: add support for shrinking and growing pipes)
added capability to adjust pipe->buffers.

Problem is some paths don't hold pipe mutex and assume pipe->buffers
doesn't change for their duration.

Fix this by adding nr_pages_max field in struct splice_pipe_desc, and
use it in place of pipe->buffers where appropriate.

splice_shrink_spd() loses its struct pipe_inode_info argument.

Reported-by: Dave Jones <davej@redhat.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Tom Herbert <therbert@google.com>
Cc: stable <stable@vger.kernel.org> # 2.6.35
Tested-by: Dave Jones <davej@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/splice.c
include/linux/splice.h
kernel/relay.c
kernel/trace/trace.c
mm/shmem.c
net/core/skbuff.c