ASoC: rsnd: use ring buffer for rsnd_mod_name()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Fri, 9 Nov 2018 04:15:46 +0000 (04:15 +0000)
committerMark Brown <broonie@kernel.org>
Fri, 9 Nov 2018 15:45:11 +0000 (15:45 +0000)
commit0246c661b6f0051ef7bfbfff01d8ef7fd0359372
treef6ea34c76d1ee91fe094b4f83407dcd0dd83ca2c
parentd3ff06b03c106171cdc7a718c4de724ce6ae346d
ASoC: rsnd: use ring buffer for rsnd_mod_name()

commit c0ea089dbad4 ("ASoC: rsnd: rsnd_mod_name() handles both name and
ID") merged "name" and "ID" on rsnd_mod_name() to handle sub-ID
(= for CTU/BUSIF).
Then, it decided to share static char to avoid pointless memory.
But, it doesn't work correctry in below case, because last called
name will be used.

dev_xxx(dev, "%s is connected to %s\n",
rsnd_mod_name(mod_a),  /* ssiu[00] */
rsnd_mod_name(mod_b)); /* ssi[0]   */
->
rcar_sound ec500000.sound: ssi[0] is connected to ssi[0]
                           ~~~~~~                 ~~~~~~
We still don't want to have pointless memory, so let's use ring buffer.
16byte x 5 is very enough for this purpose.

dev_xxx(dev, "%s is connected to %s\n",
rsnd_mod_name(mod_a),  /* ssiu[00] */
rsnd_mod_name(mod_b)); /* ssi[0]   */
->
rcar_sound ec500000.sound: ssiu[00] is connected to ssi[0]
                           ~~~~~~~~                 ~~~~~~
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sh/rcar/core.c