vxlan: fix default fdb entry netlink notify ordering during netdev create
authorRoopa Prabhu <roopa@cumulusnetworks.com>
Wed, 4 Jul 2018 23:46:32 +0000 (16:46 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 7 Jul 2018 11:20:46 +0000 (20:20 +0900)
commit0241b836732f5f43c3f0fd9e9073c1fb24ea6757
treef5b7e5aad97f87d4d5a429662ed29d8f13cc146b
parent4c2438ba85cad3be282e19147782ef3a99717a1a
vxlan: fix default fdb entry netlink notify ordering during netdev create

Problem:
In vxlan_newlink, a default fdb entry is added before register_netdev.
The default fdb creation function also notifies user-space of the
fdb entry on the vxlan device which user-space does not know about yet.
(RTM_NEWNEIGH goes before RTM_NEWLINK for the same ifindex).

This patch fixes the user-space netlink notification ordering issue
with the following changes:
- decouple fdb notify from fdb create.
- Move fdb notify after register_netdev.
- Call rtnl_configure_link in vxlan newlink handler to notify
userspace about the newlink before fdb notify and
hence avoiding the user-space race.

Fixes: afbd8bae9c79 ("vxlan: add implicit fdb entry for default destination")
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/vxlan.c