drm/msm/dsi: Add parentheses to quirks check in dsi_phy_hw_v3_0_lane_settings
authorNathan Chancellor <natechancellor@gmail.com>
Wed, 19 Jun 2019 19:17:23 +0000 (12:17 -0700)
committerRob Clark <robdclark@chromium.org>
Wed, 19 Jun 2019 19:30:55 +0000 (12:30 -0700)
commit01a090c746697436aef0873c6f33ede44c517aec
treeaaf2fb2b2c8c44f84e53c0e91a1634edf3a3545b
parent370063ee427ae77b07c6f5dbdced608ae2ce79de
drm/msm/dsi: Add parentheses to quirks check in dsi_phy_hw_v3_0_lane_settings

Clang warns:

drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: warning: logical not is
only applied to the left hand side of this bitwise operator
[-Wlogical-not-parentheses]
        if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) {
            ^                 ~
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: note: add parentheses
after the '!' to evaluate the bitwise operator first
        if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) {
            ^
             (                                               )
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c:80:6: note: add parentheses
around left hand side expression to silence this warning
        if (!phy->cfg->quirks & V3_0_0_10NM_OLD_TIMINGS_QUIRK) {
            ^
            (                )
1 warning generated.

Add parentheses around the bitwise AND so it is evaluated first then
negated.

Fixes: 3dbbf8f09e83 ("drm/msm/dsi: Add old timings quirk for 10nm phy")
Link: https://github.com/ClangBuiltLinux/linux/issues/547
Reported-by: kbuild test robot <lkp@intel.com>
Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Reviewed-by: Sean Paul <sean@poorly.run>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/dsi/phy/dsi_phy_10nm.c