git.openwrt.org Git - openwrt/staging/ldir.git/blob

   1 From 07f411e26f82d75723df1c0c072e5602d06f4e30 Mon Sep 17 00:00:00 2001
   2 From: =?UTF-8?q?Ar=C4=B1n=C3=A7=20=C3=9CNAL?= <arinc.unal@arinc9.com>
   3 Date: Mon, 22 Jan 2024 08:35:53 +0300
   4 Subject: [PATCH 06/30] net: dsa: mt7530: use p5_interface_select as data type
   5  for p5_intf_sel
   6 MIME-Version: 1.0
   7 Content-Type: text/plain; charset=UTF-8
   8 Content-Transfer-Encoding: 8bit
   9
  10 Use the p5_interface_select enumeration as the data type for the
  11 p5_intf_sel field. This ensures p5_intf_sel can only take the values
  12 defined in the p5_interface_select enumeration.
  13
  14 Remove the explicit assignment of 0 to P5_DISABLED as the first enum item
  15 is automatically assigned 0.
  16
  17 Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com>
  18 Acked-by: Daniel Golle <daniel@makrotopia.org>
  19 Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
  20 Link: https://lore.kernel.org/r/20240122-for-netnext-mt7530-improvements-1-v3-2-042401f2b279@arinc9.com
  21 Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  22 ---
  23  drivers/net/dsa/mt7530.h | 4 ++--
  24  1 file changed, 2 insertions(+), 2 deletions(-)
  25
  26 --- a/drivers/net/dsa/mt7530.h
  27 +++ b/drivers/net/dsa/mt7530.h
  28 @@ -708,7 +708,7 @@ struct mt7530_port {
  29
  30  /* Port 5 interface select definitions */
  31  enum p5_interface_select {
  32 -       P5_DISABLED = 0,
  33 +       P5_DISABLED,
  34         P5_INTF_SEL_PHY_P0,
  35         P5_INTF_SEL_PHY_P4,
  36         P5_INTF_SEL_GMAC5,
  37 @@ -801,7 +801,7 @@ struct mt7530_priv {
  38         bool                    mcm;
  39         phy_interface_t         p6_interface;
  40         phy_interface_t         p5_interface;
  41 -       unsigned int            p5_intf_sel;
  42 +       enum p5_interface_select p5_intf_sel;
  43         u8                      mirror_rx;
  44         u8                      mirror_tx;
  45         struct mt7530_port      ports[MT7530_NUM_PORTS];