git.openwrt.org Git - openwrt/staging/nbd.git/blob

   1 From a6a1a156f5debaebf9f61850d111b966e9be9ee9 Mon Sep 17 00:00:00 2001
   2 From: Christian Lamparter <chunkeey@gmail.com>
   3 Date: Thu, 8 Jun 2023 17:36:27 +0200
   4 Subject: [PATCH] ARM: dts: BCM5301X: MR26: MR32: remove bogus nand-ecc-algo
   5  property
   6 MIME-Version: 1.0
   7 Content-Type: text/plain; charset=UTF-8
   8 Content-Transfer-Encoding: 8bit
   9
  10 | bcm53015-meraki-mr26.dtb: nand-controller@18028000:
  11 |   nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs']
  12 | From schema: Documentation/[...]/nand-controller.yaml
  13 | bcm53016-meraki-mr32.dtb: nand-controller@18028000:
  14 |   nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs']
  15 | From schema: Documentation/[...]/nand-controller.yaml
  16
  17 original ECC values for these old Merakis are sadly not
  18 provided by the vendor. It looks like Meraki just stuck
  19 with what Broadcom's SDK was doing... which left this
  20 up to the proprietary nand driver.
  21
  22 Note: The invalid setting was and is handled by brcmnand. It
  23 falls back to "bch" in brcmnand_setup_dev() when ecc.algo is
  24 set to NAND_ECC_ALGO_UNKNOWN (since "hw" is not in the list
  25 above).
  26
  27 A correct nand-ecc-algo = "bch"; is already specified in the
  28 included  "bcm5301x-nand-cs0-bch8.dtsi". So this line can be
  29 dropped.
  30
  31 Reported-by: Rafał Miłecki <zajec5@gmail.com> (per Mail)
  32 Fixes: 935327a73553 ("ARM: dts: BCM5301X: Add DT for Meraki MR26")
  33 Fixes: ec88a9c344d9 ("ARM: BCM5301X: Add DT for Meraki MR32")
  34 Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
  35 Link: https://lore.kernel.org/r/2c4d00dd40124c2ddc0b139cbce7531b108f9052.1686238550.git.chunkeey@gmail.com
  36 Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
  37 ---
  38  arch/arm/boot/dts/bcm53015-meraki-mr26.dts | 2 --
  39  arch/arm/boot/dts/bcm53016-meraki-mr32.dts | 2 --
  40  2 files changed, 4 deletions(-)
  41
  42 --- a/arch/arm/boot/dts/bcm53015-meraki-mr26.dts
  43 +++ b/arch/arm/boot/dts/bcm53015-meraki-mr26.dts
  44 @@ -72,8 +72,6 @@
  45  };
  46
  47  &nandcs {
  48 -       nand-ecc-algo = "hw";
  49 -
  50         partitions {
  51                 compatible = "fixed-partitions";
  52                 #address-cells = <0x1>;
  53 --- a/arch/arm/boot/dts/bcm53016-meraki-mr32.dts
  54 +++ b/arch/arm/boot/dts/bcm53016-meraki-mr32.dts
  55 @@ -125,8 +125,6 @@
  56  };
  57
  58  &nandcs {
  59 -       nand-ecc-algo = "hw";
  60 -
  61         partitions {
  62                 /*
  63                  * The partition autodetection does not work for this device.