git.openwrt.org Git - openwrt/openwrt.git/blob

   1 From 3d7b0ca5300bd01b176f2b4c10e173db802560d8 Mon Sep 17 00:00:00 2001
   2 From: Colin Ian King <colin.king@canonical.com>
   3 Date: Tue, 21 Jul 2020 16:06:13 +0100
   4 Subject: phy: qualcomm: fix setting of tx_deamp_3_5db when device property
   5  read fails
   6
   7 Currently when reading of the device property for "qcom,tx-deamp_3_5db"
   8 fails the default is being assigned incorrectly to phy_dwc3->rx_eq. This
   9 looks like a copy-n-paste error and in fact should be assigning the
  10 default instead to phy_dwc3->tx_deamp_3_5db
  11
  12 Addresses-Coverity: ("Copy-paste error")
  13 Fixes: ef19b117b834 ("phy: qualcomm: add qcom ipq806x dwc usb phy driver")
  14 Signed-off-by: Colin Ian King <colin.king@canonical.com>
  15 Link: https://lore.kernel.org/r/20200721150613.416876-1-colin.king@canonical.com
  16 Signed-off-by: Vinod Koul <vkoul@kernel.org>
  17 ---
  18  drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c | 2 +-
  19  1 file changed, 1 insertion(+), 1 deletion(-)
  20
  21 --- a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
  22 +++ b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
  23 @@ -531,7 +531,7 @@ static int qcom_ipq806x_usb_phy_probe(st
  24
  25         if (device_property_read_u32(&pdev->dev, "qcom,tx-deamp_3_5db",
  26                                      &phy_dwc3->tx_deamp_3_5db))
  27 -               phy_dwc3->rx_eq = SSPHY_TX_DEEMPH_3_5DB;
  28 +               phy_dwc3->tx_deamp_3_5db = SSPHY_TX_DEEMPH_3_5DB;
  29
  30         if (device_property_read_u32(&pdev->dev, "qcom,mpll", &phy_dwc3->mpll))
  31                 phy_dwc3->mpll = SSPHY_MPLL_VALUE;