git.openwrt.org Git - openwrt/staging/wigyori.git/blob

   1 From 3a767b482cacd9bfeac786837fcac419af315995 Mon Sep 17 00:00:00 2001
   2 From: Heiner Kallweit <hkallweit1@gmail.com>
   3 Date: Thu, 23 Nov 2023 10:53:26 +0100
   4 Subject: [PATCH] r8169: remove not needed check in rtl_fw_write_firmware
   5
   6 This check can never be true for a firmware file with a correct format.
   7 Existing checks in rtl_fw_data_ok() are sufficient, no problems with
   8 invalid firmware files are known.
   9
  10 Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
  11 Signed-off-by: David S. Miller <davem@davemloft.net>
  12 ---
  13  drivers/net/ethernet/realtek/r8169_firmware.c | 3 ---
  14  1 file changed, 3 deletions(-)
  15
  16 --- a/drivers/net/ethernet/realtek/r8169_firmware.c
  17 +++ b/drivers/net/ethernet/realtek/r8169_firmware.c
  18 @@ -151,9 +151,6 @@ void rtl_fw_write_firmware(struct rtl816
  19                 u32 regno = (action & 0x0fff0000) >> 16;
  20                 enum rtl_fw_opcode opcode = action >> 28;
  21
  22 -               if (!action)
  23 -                       break;
  24 -
  25                 switch (opcode) {
  26                 case PHY_READ:
  27                         predata = fw_read(tp, regno);