git.openwrt.org Git - openwrt/staging/neocturne.git/blob

   1 From 7c15430822e71e90203d87e6d0cfe83fa058b0dc Mon Sep 17 00:00:00 2001
   2 From: Len Brown <len.brown@intel.com>
   3 Date: Wed, 1 Feb 2023 12:32:01 -0600
   4 Subject: [PATCH] wifi: ath11k: allow system suspend to survive ath11k
   5
   6 When ath11k runs into internal errors upon suspend,
   7 it returns an error code to pci_pm_suspend, which
   8 aborts the entire system suspend.
   9
  10 The driver should not abort system suspend, but should
  11 keep its internal errors to itself, and allow the system
  12 to suspend.  Otherwise, a user can suspend a laptop
  13 by closing the lid and sealing it into a case, assuming
  14 that is will suspend, rather than heating up and draining
  15 the battery when in transit.
  16
  17 In practice, the ath11k device seems to have plenty of transient
  18 errors, and subsequent suspend cycles after this failure
  19 often succeed.
  20
  21 https://bugzilla.kernel.org/show_bug.cgi?id=216968
  22
  23 Fixes: d1b0c33850d29 ("ath11k: implement suspend for QCA6390 PCI devices")
  24
  25 Signed-off-by: Len Brown <len.brown@intel.com>
  26 Cc: stable@vger.kernel.org
  27 Signed-off-by: Kalle Valo <kvalo@kernel.org>
  28 Link: https://lore.kernel.org/r/20230201183201.14431-1-len.brown@intel.com
  29 ---
  30  drivers/net/wireless/ath/ath11k/pci.c | 2 +-
  31  1 file changed, 1 insertion(+), 1 deletion(-)
  32
  33 --- a/drivers/net/wireless/ath/ath11k/pci.c
  34 +++ b/drivers/net/wireless/ath/ath11k/pci.c
  35 @@ -981,7 +981,7 @@ static __maybe_unused int ath11k_pci_pm_
  36         if (ret)
  37                 ath11k_warn(ab, "failed to suspend core: %d\n", ret);
  38
  39 -       return ret;
  40 +       return 0;
  41  }
  42
  43  static __maybe_unused int ath11k_pci_pm_resume(struct device *dev)