git.openwrt.org Git - openwrt/staging/stintel.git/blob

   1 From 670fb10630bb53df3e216254be027910c4c70d00 Mon Sep 17 00:00:00 2001
   2 From: Stefan Wahren <stefan.wahren@i2se.com>
   3 Date: Sun, 21 Oct 2018 19:08:29 +0200
   4 Subject: [PATCH 236/773] staging: bcm2835-camera: Add hint about possible
   5  faulty GPU mem config
   6
   7 As per default the GPU memory config of the Raspberry Pi isn't sufficient
   8 for the camera usage. Even worse the bcm2835 camera doesn't provide a
   9 helpful error message in this case. So let's add a hint to point the user
  10 to the likely cause.
  11
  12 Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
  13 ---
  14  drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c | 5 ++++-
  15  1 file changed, 4 insertions(+), 1 deletion(-)
  16
  17 --- a/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
  18 +++ b/drivers/staging/vc04_services/bcm2835-camera/mmal-vchiq.c
  19 @@ -1620,8 +1620,11 @@ int vchiq_mmal_component_init(struct vch
  20         component = &instance->component[instance->component_idx];
  21
  22         ret = create_component(instance, component, name);
  23 -       if (ret < 0)
  24 +       if (ret < 0) {
  25 +               pr_err("%s: failed to create component %d (Not enough GPU mem?)\n",
  26 +                      __func__, ret);
  27                 goto unlock;
  28 +       }
  29
  30         /* ports info needs gathering */
  31         component->control.type = MMAL_PORT_TYPE_CONTROL;