git.openwrt.org Git - openwrt/staging/blogic.git/blob

   1 From 82ae3f4635382ff23e2ece55b5d5e713223951ec Mon Sep 17 00:00:00 2001
   2 From: Dmitry Antipov <dmantipov@yandex.ru>
   3 Date: Thu, 24 Aug 2023 10:50:44 +0300
   4 Subject: [PATCH] wifi: ath11k: drop redundant check in
   5  ath11k_dp_rx_mon_dest_process()
   6
   7 In 'ath11k_dp_rx_mon_dest_process()', 'mon_dst_srng' points to
   8 a member of 'srng_list', which is a fixed-size array inside
   9 'struct ath11k_hal'. This way, if 'ring_id' is valid (i. e.
  10 between 0 and HAL_SRNG_RING_ID_MAX - 1 inclusive), 'mon_dst_srng'
  11 can't be NULL and so relevant check may be dropped.
  12
  13 Found by Linux Verification Center (linuxtesting.org) with SVACE.
  14
  15 Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
  16 Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
  17 Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
  18 Link: https://lore.kernel.org/r/20230824075121.121144-1-dmantipov@yandex.ru
  19 ---
  20  drivers/net/wireless/ath/ath11k/dp_rx.c | 7 -------
  21  1 file changed, 7 deletions(-)
  22
  23 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c
  24 +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
  25 @@ -5094,13 +5094,6 @@ static void ath11k_dp_rx_mon_dest_proces
  26
  27         mon_dst_srng = &ar->ab->hal.srng_list[ring_id];
  28
  29 -       if (!mon_dst_srng) {
  30 -               ath11k_warn(ar->ab,
  31 -                           "HAL Monitor Destination Ring Init Failed -- %p",
  32 -                           mon_dst_srng);
  33 -               return;
  34 -       }
  35 -
  36         spin_lock_bh(&pmon->mon_lock);
  37
  38         ath11k_hal_srng_access_begin(ar->ab, mon_dst_srng);