1 From: Sebastian Gottschall <s.gottschall@newmedia-net.de>
3 Adds LED and GPIO Control support for 988x, 9887, 9888, 99x0, 9984 based
4 chipsets with on chipset connected led's using WMI Firmware API. The LED
5 device will get available named as "ath10k-phyX" at sysfs and can be controlled
6 with various triggers. adds also debugfs interface for gpio control.
8 This patch is specific for OpenWRt base, as is use old backported package
9 with old wireless source. Support for QCA9984 is removed.
10 Reworked to use ath10k-ct custom source
13 Signed-off-by: Sebastian Gottschall <s.gottschall@dd-wrt.com>
14 Reviewed-by: Steve deRosier <derosier@cal-sierra.com>
15 [kvalo: major reorg and cleanup]
16 Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
17 Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
22 * only compile tested!
24 * fix all checkpatch warnings
28 * sizeof(struct ath10k_gpiocontrol) -> sizeof(*gpio)
30 * unsigned -> unsigned int
32 * remove GPIOLIB code, that should be added in a separate patch
34 * rename gpio.c to leds.c
38 * rename some functions:
40 ath10k_attach_led() -> ath10k_leds_register()
41 ath10k_unregister_led() -> ath10k_leds_unregister()
42 ath10k_reset_led_pin() -> ath10k_leds_start()
44 * call ath10k_leds_unregister() before ath10k_thermal_unregister() to preserve ordering
46 * call ath10k_leds_start() only from ath10k_core_start() and not from mac.c
48 * rename struct ath10k_gpiocontrol as anonymous function under struct
49 ath10k::leds, no need for memory allocation
51 * merge ath10k_add_led() to ath10k_attach_led(), which is it's only caller
53 * remove #if IS_ENABLED() checks from most of places, memory savings from those were not worth it
55 * Kconfig help text improvement and move it lower in the menu, also don't enable it by default
57 * switch to set_brightness_blocking() so that the callback can sleep,
58 then no need to use ath10k_wmi_cmd_send_nowait() and can take mutex
61 * don't touch ath10k_wmi_pdev_get_temperature()
63 * as QCA6174/QCA9377 are not (yet) supported don't add the command to WMI-TLV interface
65 * remove debugfs interface, that should be added in another patch
70 ath10k-4.16/Kconfig | 10 +++
71 ath10k-4.16/Makefile | 1 +
72 ath10k-4.16/core.c | 22 +++++++
73 ath10k-4.16/core.h | 9 ++-
74 ath10k-4.16/hw.h | 1 +
75 ath10k-4.16/leds.c | 103 ++++++++++++++++++++++++++++++
76 ath10k-4.16/leds.h | 45 +++++++++++++
77 ath10k-4.16/mac.c | 1 +
78 ath10k-4.16/wmi-ops.h | 32 ++++++++++
79 ath10k-4.16/wmi-tlv.c | 2 +
80 ath10k-4.16/wmi.c | 54 ++++++++++++++++
81 ath10k-4.16/wmi.h | 35 ++++++++++
82 12 files changed, 314 insertions(+), 1 deletion(-)
83 create mode 100644 ath10k-4.16/leds.c
84 create mode 100644 ath10k-4.16/leds.h
85 --- a/ath10k-4.19/Kconfig
86 +++ b/ath10k-4.19/Kconfig
87 @@ -64,6 +64,16 @@ config ATH10K_DEBUGFS
89 If unsure, say Y to make it easier to debug problems.
92 + bool "Atheros ath10k LED support"
94 + select MAC80211_LEDS
99 + This option is necessary, if you want LED support for chipset connected led pins. If unsure, say N.
101 config ATH10K_SPECTRAL
102 bool "Atheros ath10k spectral scan support"
103 depends on ATH10K_DEBUGFS
104 --- a/ath10k-4.19/Makefile
105 +++ b/ath10k-4.19/Makefile
106 @@ -19,6 +19,7 @@ ath10k_core-$(CONFIG_ATH10K_SPECTRAL) +=
107 ath10k_core-$(CONFIG_NL80211_TESTMODE) += testmode.o
108 ath10k_core-$(CONFIG_ATH10K_TRACING) += trace.o
109 ath10k_core-$(CONFIG_THERMAL) += thermal.o
110 +ath10k_core-$(CONFIG_ATH10K_LEDS) += leds.o
111 ath10k_core-$(CONFIG_MAC80211_DEBUGFS) += debugfs_sta.o
112 ath10k_core-$(CONFIG_PM) += wow.o
113 ath10k_core-$(CONFIG_DEV_COREDUMP) += coredump.o
114 --- a/ath10k-4.19/core.c
115 +++ b/ath10k-4.19/core.c
117 #include "testmode.h"
119 #include "coredump.h"
122 /* Disable ath10k-ct DBGLOG output by default */
123 unsigned int ath10k_debug_mask = ATH10K_DBG_NO_DBGLOG;
124 @@ -72,6 +73,7 @@ static const struct ath10k_hw_params ath
125 .id = QCA988X_HW_2_0_VERSION,
126 .dev_id = QCA988X_2_0_DEVICE_ID,
127 .name = "qca988x hw2.0",
129 .patch_load_addr = QCA988X_HW_2_0_PATCH_LOAD_ADDR,
131 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_ALL,
132 @@ -137,6 +139,7 @@ static const struct ath10k_hw_params ath
133 .id = QCA9887_HW_1_0_VERSION,
134 .dev_id = QCA9887_1_0_DEVICE_ID,
135 .name = "qca9887 hw1.0",
137 .patch_load_addr = QCA9887_HW_1_0_PATCH_LOAD_ADDR,
139 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_ALL,
140 @@ -301,6 +304,7 @@ static const struct ath10k_hw_params ath
141 .id = QCA99X0_HW_2_0_DEV_VERSION,
142 .dev_id = QCA99X0_2_0_DEVICE_ID,
143 .name = "qca99x0 hw2.0",
145 .patch_load_addr = QCA99X0_HW_2_0_PATCH_LOAD_ADDR,
147 .otp_exe_param = 0x00000700,
148 @@ -339,6 +343,7 @@ static const struct ath10k_hw_params ath
149 .id = QCA9984_HW_1_0_DEV_VERSION,
150 .dev_id = QCA9984_1_0_DEVICE_ID,
151 .name = "qca9984/qca9994 hw1.0",
153 .patch_load_addr = QCA9984_HW_1_0_PATCH_LOAD_ADDR,
155 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_EACH,
156 @@ -382,6 +387,7 @@ static const struct ath10k_hw_params ath
157 .id = QCA9888_HW_2_0_DEV_VERSION,
158 .dev_id = QCA9888_2_0_DEVICE_ID,
159 .name = "qca9888 hw2.0",
161 .patch_load_addr = QCA9888_HW_2_0_PATCH_LOAD_ADDR,
163 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_EACH,
164 @@ -3176,6 +3182,10 @@ int ath10k_core_start(struct ath10k *ar,
165 ath10k_wmi_check_apply_board_power_ctl_table(ar);
168 + status = ath10k_leds_start(ar);
175 @@ -3430,9 +3440,18 @@ static void ath10k_core_register_work(st
176 goto err_spectral_destroy;
179 + status = ath10k_leds_register(ar);
181 + ath10k_err(ar, "could not register leds: %d\n",
183 + goto err_thermal_unregister;
186 set_bit(ATH10K_FLAG_CORE_REGISTERED, &ar->dev_flags);
189 +err_thermal_unregister:
190 + ath10k_thermal_unregister(ar);
191 err_spectral_destroy:
192 ath10k_spectral_destroy(ar);
194 @@ -3490,6 +3509,8 @@ void ath10k_core_unregister(struct ath10
195 if (!test_bit(ATH10K_FLAG_CORE_REGISTERED, &ar->dev_flags))
198 + ath10k_leds_unregister(ar);
200 ath10k_thermal_unregister(ar);
201 /* Stop spectral before unregistering from mac80211 to remove the
202 * relayfs debugfs file cleanly. Otherwise the parent debugfs tree
203 --- a/ath10k-4.19/core.h
204 +++ b/ath10k-4.19/core.h
206 #include <linux/pci.h>
207 #include <linux/uuid.h>
208 #include <linux/time.h>
209 +#include <linux/leds.h>
213 @@ -1138,7 +1139,6 @@ struct ath10k {
219 bool ct_all_pkts_htt; /* CT firmware only: native-wifi for all pkts */
221 @@ -1391,6 +1391,13 @@ struct ath10k {
225 + struct gpio_led wifi_led;
226 + struct led_classdev cdev;
228 + u32 gpio_state_pin;
232 /* protected by data_lock */
233 u32 fw_crash_counter;
234 u32 fw_warm_reset_counter;
235 --- a/ath10k-4.19/hw.h
236 +++ b/ath10k-4.19/hw.h
237 @@ -508,6 +508,7 @@ struct ath10k_hw_params {
244 /* Type of hw cycle counter wraparound logic, for more info
246 +++ b/ath10k-4.19/leds.c
249 + * Copyright (c) 2005-2011 Atheros Communications Inc.
250 + * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
251 + * Copyright (c) 2018 Sebastian Gottschall <s.gottschall@dd-wrt.com>
252 + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
254 + * Permission to use, copy, modify, and/or distribute this software for any
255 + * purpose with or without fee is hereby granted, provided that the above
256 + * copyright notice and this permission notice appear in all copies.
258 + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
259 + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
260 + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
261 + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
262 + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
263 + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
264 + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
267 +#include <linux/leds.h>
271 +#include "wmi-ops.h"
275 +static int ath10k_leds_set_brightness_blocking(struct led_classdev *led_cdev,
276 + enum led_brightness brightness)
278 + struct ath10k *ar = container_of(led_cdev, struct ath10k,
280 + struct gpio_led *led = &ar->leds.wifi_led;
282 + mutex_lock(&ar->conf_mutex);
284 + if (ar->state != ATH10K_STATE_ON)
287 + ar->leds.gpio_state_pin = (brightness != LED_OFF) ^ led->active_low;
288 + ath10k_wmi_gpio_output(ar, led->gpio, ar->leds.gpio_state_pin);
291 + mutex_unlock(&ar->conf_mutex);
296 +int ath10k_leds_start(struct ath10k *ar)
298 + if (ar->hw_params.led_pin == 0)
299 + /* leds not supported */
302 + /* under some circumstances, the gpio pin gets reconfigured
303 + * to default state by the firmware, so we need to
304 + * reconfigure it this behaviour has only ben seen on
305 + * QCA9984 and QCA99XX devices so far
307 + ath10k_wmi_gpio_config(ar, ar->hw_params.led_pin, 0,
308 + WMI_GPIO_PULL_NONE, WMI_GPIO_INTTYPE_DISABLE);
309 + ath10k_wmi_gpio_output(ar, ar->hw_params.led_pin, 1);
314 +int ath10k_leds_register(struct ath10k *ar)
318 + if (ar->hw_params.led_pin == 0)
319 + /* leds not supported */
322 + snprintf(ar->leds.label, sizeof(ar->leds.label), "ath10k-%s",
323 + wiphy_name(ar->hw->wiphy));
324 + ar->leds.wifi_led.active_low = 1;
325 + ar->leds.wifi_led.gpio = ar->hw_params.led_pin;
326 + ar->leds.wifi_led.name = ar->leds.label;
327 + ar->leds.wifi_led.default_state = LEDS_GPIO_DEFSTATE_KEEP;
329 + ar->leds.cdev.name = ar->leds.label;
330 + ar->leds.cdev.brightness_set_blocking = ath10k_leds_set_brightness_blocking;
332 + /* FIXME: this assignment doesn't make sense as it's NULL, remove it? */
333 + ar->leds.cdev.default_trigger = ar->leds.wifi_led.default_trigger;
335 + ret = led_classdev_register(wiphy_dev(ar->hw->wiphy), &ar->leds.cdev);
342 +void ath10k_leds_unregister(struct ath10k *ar)
344 + if (ar->hw_params.led_pin == 0)
345 + /* leds not supported */
348 + led_classdev_unregister(&ar->leds.cdev);
352 +++ b/ath10k-4.19/leds.h
355 + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
357 + * Permission to use, copy, modify, and/or distribute this software for any
358 + * purpose with or without fee is hereby granted, provided that the above
359 + * copyright notice and this permission notice appear in all copies.
361 + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
362 + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
363 + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
364 + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
365 + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
366 + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
367 + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
374 +#ifdef CONFIG_ATH10K_LEDS
375 +void ath10k_leds_unregister(struct ath10k *ar);
376 +int ath10k_leds_start(struct ath10k *ar);
377 +int ath10k_leds_register(struct ath10k *ar);
379 +static inline void ath10k_leds_unregister(struct ath10k *ar)
383 +static inline int ath10k_leds_start(struct ath10k *ar)
388 +static inline int ath10k_leds_register(struct ath10k *ar)
394 +#endif /* _LEDS_H_ */
395 --- a/ath10k-4.19/mac.c
396 +++ b/ath10k-4.19/mac.c
405 --- a/ath10k-4.19/wmi-ops.h
406 +++ b/ath10k-4.19/wmi-ops.h
407 @@ -218,7 +218,10 @@ struct wmi_ops {
408 struct sk_buff *(*gen_echo)(struct ath10k *ar, u32 value);
409 struct sk_buff *(*gen_pdev_get_tpc_table_cmdid)(struct ath10k *ar,
411 + struct sk_buff *(*gen_gpio_config)(struct ath10k *ar, u32 gpio_num,
412 + u32 input, u32 pull_type, u32 intr_mode);
414 + struct sk_buff *(*gen_gpio_output)(struct ath10k *ar, u32 gpio_num, u32 set);
417 int ath10k_wmi_cmd_send(struct ath10k *ar, struct sk_buff *skb, u32 cmd_id);
418 @@ -1079,6 +1082,35 @@ ath10k_wmi_force_fw_hang(struct ath10k *
419 return ath10k_wmi_cmd_send(ar, skb, ar->wmi.cmd->force_fw_hang_cmdid);
422 +static inline int ath10k_wmi_gpio_config(struct ath10k *ar, u32 gpio_num,
423 + u32 input, u32 pull_type, u32 intr_mode)
425 + struct sk_buff *skb;
427 + if (!ar->wmi.ops->gen_gpio_config)
428 + return -EOPNOTSUPP;
430 + skb = ar->wmi.ops->gen_gpio_config(ar, gpio_num, input, pull_type, intr_mode);
432 + return PTR_ERR(skb);
434 + return ath10k_wmi_cmd_send(ar, skb, ar->wmi.cmd->gpio_config_cmdid);
437 +static inline int ath10k_wmi_gpio_output(struct ath10k *ar, u32 gpio_num, u32 set)
439 + struct sk_buff *skb;
441 + if (!ar->wmi.ops->gen_gpio_config)
442 + return -EOPNOTSUPP;
444 + skb = ar->wmi.ops->gen_gpio_output(ar, gpio_num, set);
446 + return PTR_ERR(skb);
448 + return ath10k_wmi_cmd_send(ar, skb, ar->wmi.cmd->gpio_output_cmdid);
452 ath10k_wmi_dbglog_cfg(struct ath10k *ar, u64 module_enable, u32 log_level)
454 --- a/ath10k-4.19/wmi-tlv.c
455 +++ b/ath10k-4.19/wmi-tlv.c
456 @@ -3976,6 +3976,8 @@ static const struct wmi_ops wmi_tlv_ops
457 .gen_echo = ath10k_wmi_tlv_op_gen_echo,
458 .gen_vdev_spectral_conf = ath10k_wmi_tlv_op_gen_vdev_spectral_conf,
459 .gen_vdev_spectral_enable = ath10k_wmi_tlv_op_gen_vdev_spectral_enable,
460 + /* .gen_gpio_config not implemented */
461 + /* .gen_gpio_output not implemented */
464 static const struct wmi_peer_flags_map wmi_tlv_peer_flags_map = {
465 --- a/ath10k-4.19/wmi.c
466 +++ b/ath10k-4.19/wmi.c
467 @@ -8071,6 +8071,49 @@ ath10k_wmi_op_gen_peer_set_param(struct
471 +static struct sk_buff *ath10k_wmi_op_gen_gpio_config(struct ath10k *ar,
472 + u32 gpio_num, u32 input,
473 + u32 pull_type, u32 intr_mode)
475 + struct wmi_gpio_config_cmd *cmd;
476 + struct sk_buff *skb;
478 + skb = ath10k_wmi_alloc_skb(ar, sizeof(*cmd));
480 + return ERR_PTR(-ENOMEM);
482 + cmd = (struct wmi_gpio_config_cmd *)skb->data;
483 + cmd->pull_type = __cpu_to_le32(pull_type);
484 + cmd->gpio_num = __cpu_to_le32(gpio_num);
485 + cmd->input = __cpu_to_le32(input);
486 + cmd->intr_mode = __cpu_to_le32(intr_mode);
488 + ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi gpio_config gpio_num 0x%08x input 0x%08x pull_type 0x%08x intr_mode 0x%08x\n",
489 + gpio_num, input, pull_type, intr_mode);
494 +static struct sk_buff *ath10k_wmi_op_gen_gpio_output(struct ath10k *ar,
495 + u32 gpio_num, u32 set)
497 + struct wmi_gpio_output_cmd *cmd;
498 + struct sk_buff *skb;
500 + skb = ath10k_wmi_alloc_skb(ar, sizeof(*cmd));
502 + return ERR_PTR(-ENOMEM);
504 + cmd = (struct wmi_gpio_output_cmd *)skb->data;
505 + cmd->gpio_num = __cpu_to_le32(gpio_num);
506 + cmd->set = __cpu_to_le32(set);
508 + ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi gpio_output gpio_num 0x%08x set 0x%08x\n",
514 static struct sk_buff *
515 ath10k_wmi_op_gen_set_psmode(struct ath10k *ar, u32 vdev_id,
516 enum wmi_sta_ps_mode psmode)
517 @@ -9824,6 +9867,9 @@ static const struct wmi_ops wmi_ops = {
518 .fw_stats_fill = ath10k_wmi_main_op_fw_stats_fill,
519 .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
520 .gen_echo = ath10k_wmi_op_gen_echo,
521 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
522 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
524 /* .gen_bcn_tmpl not implemented */
525 /* .gen_prb_tmpl not implemented */
526 /* .gen_p2p_go_bcn_ie not implemented */
527 @@ -9894,6 +9940,8 @@ static const struct wmi_ops wmi_10_1_ops
528 .fw_stats_fill = ath10k_wmi_10x_op_fw_stats_fill,
529 .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
530 .gen_echo = ath10k_wmi_op_gen_echo,
531 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
532 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
533 /* .gen_bcn_tmpl not implemented */
534 /* .gen_prb_tmpl not implemented */
535 /* .gen_p2p_go_bcn_ie not implemented */
536 @@ -9972,6 +10020,8 @@ static const struct wmi_ops wmi_10_2_ops
537 .gen_delba_send = ath10k_wmi_op_gen_delba_send,
538 .fw_stats_fill = ath10k_wmi_10x_op_fw_stats_fill,
539 .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
540 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
541 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
542 /* .gen_pdev_enable_adaptive_cca not implemented */
545 @@ -10042,6 +10092,8 @@ static const struct wmi_ops wmi_10_2_4_o
546 .gen_pdev_enable_adaptive_cca =
547 ath10k_wmi_op_gen_pdev_enable_adaptive_cca,
548 .get_vdev_subtype = ath10k_wmi_10_2_4_op_get_vdev_subtype,
549 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
550 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
551 /* .gen_bcn_tmpl not implemented */
552 /* .gen_prb_tmpl not implemented */
553 /* .gen_p2p_go_bcn_ie not implemented */
554 @@ -10122,6 +10174,8 @@ static const struct wmi_ops wmi_10_4_ops
555 .gen_pdev_bss_chan_info_req = ath10k_wmi_10_2_op_gen_pdev_bss_chan_info,
556 .gen_echo = ath10k_wmi_op_gen_echo,
557 .gen_pdev_get_tpc_config = ath10k_wmi_10_2_4_op_gen_pdev_get_tpc_config,
558 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
559 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
562 int ath10k_wmi_attach(struct ath10k *ar)
563 --- a/ath10k-4.19/wmi.h
564 +++ b/ath10k-4.19/wmi.h
565 @@ -3084,6 +3084,41 @@ enum wmi_10_4_feature_mask {
569 +/* WMI_GPIO_CONFIG_CMDID */
571 + WMI_GPIO_PULL_NONE,
573 + WMI_GPIO_PULL_DOWN,
577 + WMI_GPIO_INTTYPE_DISABLE,
578 + WMI_GPIO_INTTYPE_RISING_EDGE,
579 + WMI_GPIO_INTTYPE_FALLING_EDGE,
580 + WMI_GPIO_INTTYPE_BOTH_EDGE,
581 + WMI_GPIO_INTTYPE_LEVEL_LOW,
582 + WMI_GPIO_INTTYPE_LEVEL_HIGH
585 +/* WMI_GPIO_CONFIG_CMDID */
586 +struct wmi_gpio_config_cmd {
587 + __le32 gpio_num; /* GPIO number to be setup */
588 + __le32 input; /* 0 - Output/ 1 - Input */
589 + __le32 pull_type; /* Pull type defined above */
590 + __le32 intr_mode; /* Interrupt mode defined above (Input) */
593 +/* WMI_GPIO_OUTPUT_CMDID */
594 +struct wmi_gpio_output_cmd {
595 + __le32 gpio_num; /* GPIO number to be setup */
596 + __le32 set; /* Set the GPIO pin*/
599 +/* WMI_GPIO_INPUT_EVENTID */
600 +struct wmi_gpio_input_event {
601 + __le32 gpio_num; /* GPIO number which changed state */
604 struct wmi_ext_resource_config_10_4_cmd {
605 /* contains enum wmi_host_platform_type */
606 __le32 host_platform_config;
607 --- a/ath10k-5.2/Kconfig
608 +++ b/ath10k-5.2/Kconfig
609 @@ -66,6 +66,16 @@ config ATH10K_DEBUGFS
611 If unsure, say Y to make it easier to debug problems.
614 + bool "Atheros ath10k LED support"
616 + select MAC80211_LEDS
621 + This option is necessary, if you want LED support for chipset connected led pins. If unsure, say N.
623 config ATH10K_SPECTRAL
624 bool "Atheros ath10k spectral scan support"
625 depends on ATH10K_DEBUGFS
626 --- a/ath10k-5.2/Makefile
627 +++ b/ath10k-5.2/Makefile
628 @@ -19,6 +19,7 @@ ath10k_core-$(CONFIG_ATH10K_SPECTRAL) +=
629 ath10k_core-$(CONFIG_NL80211_TESTMODE) += testmode.o
630 ath10k_core-$(CONFIG_ATH10K_TRACING) += trace.o
631 ath10k_core-$(CONFIG_THERMAL) += thermal.o
632 +ath10k_core-$(CONFIG_ATH10K_LEDS) += leds.o
633 ath10k_core-$(CONFIG_MAC80211_DEBUGFS) += debugfs_sta.o
634 ath10k_core-$(CONFIG_PM) += wow.o
635 ath10k_core-$(CONFIG_DEV_COREDUMP) += coredump.o
636 --- a/ath10k-5.2/core.c
637 +++ b/ath10k-5.2/core.c
639 #include "testmode.h"
641 #include "coredump.h"
644 /* Disable ath10k-ct DBGLOG output by default */
645 unsigned int ath10k_debug_mask = ATH10K_DBG_NO_DBGLOG;
646 @@ -63,6 +64,7 @@ static const struct ath10k_hw_params ath
647 .dev_id = QCA988X_2_0_DEVICE_ID,
648 .bus = ATH10K_BUS_PCI,
649 .name = "qca988x hw2.0",
651 .patch_load_addr = QCA988X_HW_2_0_PATCH_LOAD_ADDR,
653 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_ALL,
654 @@ -131,6 +133,7 @@ static const struct ath10k_hw_params ath
655 .dev_id = QCA9887_1_0_DEVICE_ID,
656 .bus = ATH10K_BUS_PCI,
657 .name = "qca9887 hw1.0",
659 .patch_load_addr = QCA9887_HW_1_0_PATCH_LOAD_ADDR,
661 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_ALL,
662 @@ -305,6 +308,7 @@ static const struct ath10k_hw_params ath
663 .dev_id = QCA99X0_2_0_DEVICE_ID,
664 .bus = ATH10K_BUS_PCI,
665 .name = "qca99x0 hw2.0",
667 .patch_load_addr = QCA99X0_HW_2_0_PATCH_LOAD_ADDR,
669 .otp_exe_param = 0x00000700,
670 @@ -345,6 +349,7 @@ static const struct ath10k_hw_params ath
671 .dev_id = QCA9984_1_0_DEVICE_ID,
672 .bus = ATH10K_BUS_PCI,
673 .name = "qca9984/qca9994 hw1.0",
675 .patch_load_addr = QCA9984_HW_1_0_PATCH_LOAD_ADDR,
677 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_EACH,
678 @@ -392,6 +397,7 @@ static const struct ath10k_hw_params ath
679 .dev_id = QCA9888_2_0_DEVICE_ID,
680 .bus = ATH10K_BUS_PCI,
681 .name = "qca9888 hw2.0",
683 .patch_load_addr = QCA9888_HW_2_0_PATCH_LOAD_ADDR,
685 .cc_wraparound_type = ATH10K_HW_CC_WRAP_SHIFTED_EACH,
686 @@ -3503,6 +3509,10 @@ int ath10k_core_start(struct ath10k *ar,
687 ath10k_wmi_check_apply_board_power_ctl_table(ar);
690 + status = ath10k_leds_start(ar);
697 @@ -3759,9 +3769,18 @@ static void ath10k_core_register_work(st
698 goto err_spectral_destroy;
701 + status = ath10k_leds_register(ar);
703 + ath10k_err(ar, "could not register leds: %d\n",
705 + goto err_thermal_unregister;
708 set_bit(ATH10K_FLAG_CORE_REGISTERED, &ar->dev_flags);
711 +err_thermal_unregister:
712 + ath10k_thermal_unregister(ar);
713 err_spectral_destroy:
714 ath10k_spectral_destroy(ar);
716 @@ -3821,6 +3840,8 @@ void ath10k_core_unregister(struct ath10
717 if (!test_bit(ATH10K_FLAG_CORE_REGISTERED, &ar->dev_flags))
720 + ath10k_leds_unregister(ar);
722 ath10k_thermal_unregister(ar);
723 /* Stop spectral before unregistering from mac80211 to remove the
724 * relayfs debugfs file cleanly. Otherwise the parent debugfs tree
725 --- a/ath10k-5.2/core.h
726 +++ b/ath10k-5.2/core.h
728 #include <linux/pci.h>
729 #include <linux/uuid.h>
730 #include <linux/time.h>
731 +#include <linux/leds.h>
735 @@ -1449,6 +1450,13 @@ struct ath10k {
739 + struct gpio_led wifi_led;
740 + struct led_classdev cdev;
742 + u32 gpio_state_pin;
746 /* protected by data_lock */
747 u32 fw_crash_counter;
748 u32 fw_warm_reset_counter;
749 --- a/ath10k-5.2/hw.h
750 +++ b/ath10k-5.2/hw.h
751 @@ -515,6 +515,7 @@ struct ath10k_hw_params {
758 /* Type of hw cycle counter wraparound logic, for more info
760 +++ b/ath10k-5.2/leds.c
763 + * Copyright (c) 2005-2011 Atheros Communications Inc.
764 + * Copyright (c) 2011-2017 Qualcomm Atheros, Inc.
765 + * Copyright (c) 2018 Sebastian Gottschall <s.gottschall@dd-wrt.com>
766 + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
768 + * Permission to use, copy, modify, and/or distribute this software for any
769 + * purpose with or without fee is hereby granted, provided that the above
770 + * copyright notice and this permission notice appear in all copies.
772 + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
773 + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
774 + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
775 + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
776 + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
777 + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
778 + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
781 +#include <linux/leds.h>
785 +#include "wmi-ops.h"
789 +static int ath10k_leds_set_brightness_blocking(struct led_classdev *led_cdev,
790 + enum led_brightness brightness)
792 + struct ath10k *ar = container_of(led_cdev, struct ath10k,
794 + struct gpio_led *led = &ar->leds.wifi_led;
796 + mutex_lock(&ar->conf_mutex);
798 + if (ar->state != ATH10K_STATE_ON)
801 + ar->leds.gpio_state_pin = (brightness != LED_OFF) ^ led->active_low;
802 + ath10k_wmi_gpio_output(ar, led->gpio, ar->leds.gpio_state_pin);
805 + mutex_unlock(&ar->conf_mutex);
810 +int ath10k_leds_start(struct ath10k *ar)
812 + if (ar->hw_params.led_pin == 0)
813 + /* leds not supported */
816 + /* under some circumstances, the gpio pin gets reconfigured
817 + * to default state by the firmware, so we need to
818 + * reconfigure it this behaviour has only ben seen on
819 + * QCA9984 and QCA99XX devices so far
821 + ath10k_wmi_gpio_config(ar, ar->hw_params.led_pin, 0,
822 + WMI_GPIO_PULL_NONE, WMI_GPIO_INTTYPE_DISABLE);
823 + ath10k_wmi_gpio_output(ar, ar->hw_params.led_pin, 1);
828 +int ath10k_leds_register(struct ath10k *ar)
832 + if (ar->hw_params.led_pin == 0)
833 + /* leds not supported */
836 + snprintf(ar->leds.label, sizeof(ar->leds.label), "ath10k-%s",
837 + wiphy_name(ar->hw->wiphy));
838 + ar->leds.wifi_led.active_low = 1;
839 + ar->leds.wifi_led.gpio = ar->hw_params.led_pin;
840 + ar->leds.wifi_led.name = ar->leds.label;
841 + ar->leds.wifi_led.default_state = LEDS_GPIO_DEFSTATE_KEEP;
843 + ar->leds.cdev.name = ar->leds.label;
844 + ar->leds.cdev.brightness_set_blocking = ath10k_leds_set_brightness_blocking;
846 + /* FIXME: this assignment doesn't make sense as it's NULL, remove it? */
847 + ar->leds.cdev.default_trigger = ar->leds.wifi_led.default_trigger;
849 + ret = led_classdev_register(wiphy_dev(ar->hw->wiphy), &ar->leds.cdev);
856 +void ath10k_leds_unregister(struct ath10k *ar)
858 + if (ar->hw_params.led_pin == 0)
859 + /* leds not supported */
862 + led_classdev_unregister(&ar->leds.cdev);
866 +++ b/ath10k-5.2/leds.h
869 + * Copyright (c) 2018, The Linux Foundation. All rights reserved.
871 + * Permission to use, copy, modify, and/or distribute this software for any
872 + * purpose with or without fee is hereby granted, provided that the above
873 + * copyright notice and this permission notice appear in all copies.
875 + * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
876 + * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
877 + * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
878 + * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
879 + * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
880 + * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
881 + * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
888 +#ifdef CONFIG_ATH10K_LEDS
889 +void ath10k_leds_unregister(struct ath10k *ar);
890 +int ath10k_leds_start(struct ath10k *ar);
891 +int ath10k_leds_register(struct ath10k *ar);
893 +static inline void ath10k_leds_unregister(struct ath10k *ar)
897 +static inline int ath10k_leds_start(struct ath10k *ar)
902 +static inline int ath10k_leds_register(struct ath10k *ar)
908 +#endif /* _LEDS_H_ */
909 --- a/ath10k-5.2/mac.c
910 +++ b/ath10k-5.2/mac.c
919 --- a/ath10k-5.2/wmi-ops.h
920 +++ b/ath10k-5.2/wmi-ops.h
921 @@ -218,7 +218,10 @@ struct wmi_ops {
922 struct sk_buff *(*gen_bb_timing)
924 const struct wmi_bb_timing_cfg_arg *arg);
925 + struct sk_buff *(*gen_gpio_config)(struct ath10k *ar, u32 gpio_num,
926 + u32 input, u32 pull_type, u32 intr_mode);
928 + struct sk_buff *(*gen_gpio_output)(struct ath10k *ar, u32 gpio_num, u32 set);
931 int ath10k_wmi_cmd_send(struct ath10k *ar, struct sk_buff *skb, u32 cmd_id);
932 @@ -1105,6 +1108,35 @@ ath10k_wmi_force_fw_hang(struct ath10k *
933 return ath10k_wmi_cmd_send(ar, skb, ar->wmi.cmd->force_fw_hang_cmdid);
936 +static inline int ath10k_wmi_gpio_config(struct ath10k *ar, u32 gpio_num,
937 + u32 input, u32 pull_type, u32 intr_mode)
939 + struct sk_buff *skb;
941 + if (!ar->wmi.ops->gen_gpio_config)
942 + return -EOPNOTSUPP;
944 + skb = ar->wmi.ops->gen_gpio_config(ar, gpio_num, input, pull_type, intr_mode);
946 + return PTR_ERR(skb);
948 + return ath10k_wmi_cmd_send(ar, skb, ar->wmi.cmd->gpio_config_cmdid);
951 +static inline int ath10k_wmi_gpio_output(struct ath10k *ar, u32 gpio_num, u32 set)
953 + struct sk_buff *skb;
955 + if (!ar->wmi.ops->gen_gpio_config)
956 + return -EOPNOTSUPP;
958 + skb = ar->wmi.ops->gen_gpio_output(ar, gpio_num, set);
960 + return PTR_ERR(skb);
962 + return ath10k_wmi_cmd_send(ar, skb, ar->wmi.cmd->gpio_output_cmdid);
966 ath10k_wmi_dbglog_cfg(struct ath10k *ar, u64 module_enable, u32 log_level)
968 --- a/ath10k-5.2/wmi-tlv.c
969 +++ b/ath10k-5.2/wmi-tlv.c
970 @@ -4311,6 +4311,8 @@ static const struct wmi_ops wmi_tlv_ops
971 .gen_echo = ath10k_wmi_tlv_op_gen_echo,
972 .gen_vdev_spectral_conf = ath10k_wmi_tlv_op_gen_vdev_spectral_conf,
973 .gen_vdev_spectral_enable = ath10k_wmi_tlv_op_gen_vdev_spectral_enable,
974 + /* .gen_gpio_config not implemented */
975 + /* .gen_gpio_output not implemented */
978 static const struct wmi_peer_flags_map wmi_tlv_peer_flags_map = {
979 --- a/ath10k-5.2/wmi.c
980 +++ b/ath10k-5.2/wmi.c
981 @@ -8295,6 +8295,49 @@ ath10k_wmi_op_gen_peer_set_param(struct
985 +static struct sk_buff *ath10k_wmi_op_gen_gpio_config(struct ath10k *ar,
986 + u32 gpio_num, u32 input,
987 + u32 pull_type, u32 intr_mode)
989 + struct wmi_gpio_config_cmd *cmd;
990 + struct sk_buff *skb;
992 + skb = ath10k_wmi_alloc_skb(ar, sizeof(*cmd));
994 + return ERR_PTR(-ENOMEM);
996 + cmd = (struct wmi_gpio_config_cmd *)skb->data;
997 + cmd->pull_type = __cpu_to_le32(pull_type);
998 + cmd->gpio_num = __cpu_to_le32(gpio_num);
999 + cmd->input = __cpu_to_le32(input);
1000 + cmd->intr_mode = __cpu_to_le32(intr_mode);
1002 + ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi gpio_config gpio_num 0x%08x input 0x%08x pull_type 0x%08x intr_mode 0x%08x\n",
1003 + gpio_num, input, pull_type, intr_mode);
1008 +static struct sk_buff *ath10k_wmi_op_gen_gpio_output(struct ath10k *ar,
1009 + u32 gpio_num, u32 set)
1011 + struct wmi_gpio_output_cmd *cmd;
1012 + struct sk_buff *skb;
1014 + skb = ath10k_wmi_alloc_skb(ar, sizeof(*cmd));
1016 + return ERR_PTR(-ENOMEM);
1018 + cmd = (struct wmi_gpio_output_cmd *)skb->data;
1019 + cmd->gpio_num = __cpu_to_le32(gpio_num);
1020 + cmd->set = __cpu_to_le32(set);
1022 + ath10k_dbg(ar, ATH10K_DBG_WMI, "wmi gpio_output gpio_num 0x%08x set 0x%08x\n",
1028 static struct sk_buff *
1029 ath10k_wmi_op_gen_set_psmode(struct ath10k *ar, u32 vdev_id,
1030 enum wmi_sta_ps_mode psmode)
1031 @@ -10069,6 +10112,9 @@ static const struct wmi_ops wmi_ops = {
1032 .fw_stats_fill = ath10k_wmi_main_op_fw_stats_fill,
1033 .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
1034 .gen_echo = ath10k_wmi_op_gen_echo,
1035 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
1036 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
1038 /* .gen_bcn_tmpl not implemented */
1039 /* .gen_prb_tmpl not implemented */
1040 /* .gen_p2p_go_bcn_ie not implemented */
1041 @@ -10139,6 +10185,8 @@ static const struct wmi_ops wmi_10_1_ops
1042 .fw_stats_fill = ath10k_wmi_10x_op_fw_stats_fill,
1043 .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
1044 .gen_echo = ath10k_wmi_op_gen_echo,
1045 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
1046 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
1047 /* .gen_bcn_tmpl not implemented */
1048 /* .gen_prb_tmpl not implemented */
1049 /* .gen_p2p_go_bcn_ie not implemented */
1050 @@ -10218,6 +10266,8 @@ static const struct wmi_ops wmi_10_2_ops
1051 .gen_delba_send = ath10k_wmi_op_gen_delba_send,
1052 .fw_stats_fill = ath10k_wmi_10x_op_fw_stats_fill,
1053 .get_vdev_subtype = ath10k_wmi_op_get_vdev_subtype,
1054 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
1055 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
1056 /* .gen_pdev_enable_adaptive_cca not implemented */
1059 @@ -10289,6 +10339,8 @@ static const struct wmi_ops wmi_10_2_4_o
1060 ath10k_wmi_op_gen_pdev_enable_adaptive_cca,
1061 .get_vdev_subtype = ath10k_wmi_10_2_4_op_get_vdev_subtype,
1062 .gen_bb_timing = ath10k_wmi_10_2_4_op_gen_bb_timing,
1063 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
1064 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
1065 /* .gen_bcn_tmpl not implemented */
1066 /* .gen_prb_tmpl not implemented */
1067 /* .gen_p2p_go_bcn_ie not implemented */
1068 @@ -10370,6 +10422,8 @@ static const struct wmi_ops wmi_10_4_ops
1069 .gen_pdev_bss_chan_info_req = ath10k_wmi_10_2_op_gen_pdev_bss_chan_info,
1070 .gen_echo = ath10k_wmi_op_gen_echo,
1071 .gen_pdev_get_tpc_config = ath10k_wmi_10_2_4_op_gen_pdev_get_tpc_config,
1072 + .gen_gpio_config = ath10k_wmi_op_gen_gpio_config,
1073 + .gen_gpio_output = ath10k_wmi_op_gen_gpio_output,
1076 int ath10k_wmi_attach(struct ath10k *ar)
1077 --- a/ath10k-5.2/wmi.h
1078 +++ b/ath10k-5.2/wmi.h
1079 @@ -3103,6 +3103,41 @@ enum wmi_10_4_feature_mask {
1083 +/* WMI_GPIO_CONFIG_CMDID */
1085 + WMI_GPIO_PULL_NONE,
1087 + WMI_GPIO_PULL_DOWN,
1091 + WMI_GPIO_INTTYPE_DISABLE,
1092 + WMI_GPIO_INTTYPE_RISING_EDGE,
1093 + WMI_GPIO_INTTYPE_FALLING_EDGE,
1094 + WMI_GPIO_INTTYPE_BOTH_EDGE,
1095 + WMI_GPIO_INTTYPE_LEVEL_LOW,
1096 + WMI_GPIO_INTTYPE_LEVEL_HIGH
1099 +/* WMI_GPIO_CONFIG_CMDID */
1100 +struct wmi_gpio_config_cmd {
1101 + __le32 gpio_num; /* GPIO number to be setup */
1102 + __le32 input; /* 0 - Output/ 1 - Input */
1103 + __le32 pull_type; /* Pull type defined above */
1104 + __le32 intr_mode; /* Interrupt mode defined above (Input) */
1107 +/* WMI_GPIO_OUTPUT_CMDID */
1108 +struct wmi_gpio_output_cmd {
1109 + __le32 gpio_num; /* GPIO number to be setup */
1110 + __le32 set; /* Set the GPIO pin*/
1113 +/* WMI_GPIO_INPUT_EVENTID */
1114 +struct wmi_gpio_input_event {
1115 + __le32 gpio_num; /* GPIO number which changed state */
1118 struct wmi_ext_resource_config_10_4_cmd {
1119 /* contains enum wmi_host_platform_type */
1120 __le32 host_platform_config;