git.openwrt.org Git - openwrt/staging/blocktrron.git/blob

   1 From 854d71c555dfc3383c1fde7d9989b6046e21093d Mon Sep 17 00:00:00 2001
   2 From: Heiner Kallweit <hkallweit1@gmail.com>
   3 Date: Wed, 9 Oct 2024 07:48:05 +0200
   4 Subject: [PATCH] r8169: remove original workaround for RTL8125 broken rx issue
   5
   6 Now that we have b9c7ac4fe22c ("r8169: disable ALDPS per default for
   7 RTL8125"), the first attempt to fix the issue shouldn't be needed
   8 any longer. So let's effectively revert 621735f59064 ("r8169: fix
   9 rare issue with broken rx after link-down on RTL8125") and see
  10 whether anybody complains.
  11
  12 Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
  13 Reviewed-by: Simon Horman <horms@kernel.org>
  14 Link: https://patch.msgid.link/382d8c88-cbce-400f-ad62-fda0181c7e38@gmail.com
  15 Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  16 ---
  17  drivers/net/ethernet/realtek/r8169_main.c | 4 ----
  18  1 file changed, 4 deletions(-)
  19
  20 --- a/drivers/net/ethernet/realtek/r8169_main.c
  21 +++ b/drivers/net/ethernet/realtek/r8169_main.c
  22 @@ -4779,11 +4779,7 @@ static void r8169_phylink_handler(struct
  23         if (netif_carrier_ok(ndev)) {
  24                 rtl_link_chg_patch(tp);
  25                 pm_request_resume(d);
  26 -               netif_wake_queue(tp->dev);
  27         } else {
  28 -               /* In few cases rx is broken after link-down otherwise */
  29 -               if (rtl_is_8125(tp))
  30 -                       rtl_schedule_task(tp, RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE);
  31                 pm_runtime_idle(d);
  32         }
  33