git.openwrt.org Git - openwrt/staging/stintel.git/blob

   1 From 161327f91d956771996c96ea1b6e4e1cb8dc074c Mon Sep 17 00:00:00 2001
   2 From: Stone Zhang <quic_stonez@quicinc.com>
   3 Date: Mon, 14 Oct 2024 18:47:32 +0800
   4 Subject: [PATCH] hostapd: Fix clearing up settings for color switch
   5
   6 Settings for color switch (struct cca_settings settings)
   7 is used without zero clearing, which causes the member
   8 settings->ubpr->unsol_bcast_probe_resp_intervalettings
   9 to be a random value. It is againsts the NLA policy of
  10 NL80211_UNSOL_BCAST_PROBE_RESP_ATTR_INT and causes
  11 BSS color switch failure.
  12
  13 Fixes: 654d2395dddf ("BSS coloring: Handling of collision events and triggering CCA")
  14 Signed-off-by: Stone Zhang <quic_stonez@quicinc.com>
  15 ---
  16  src/ap/hostapd.c | 1 +
  17  1 file changed, 1 insertion(+)
  18
  19 --- a/src/ap/hostapd.c
  20 +++ b/src/ap/hostapd.c
  21 @@ -4813,6 +4813,7 @@ static void hostapd_switch_color_timeout
  22                 struct cca_settings settings;
  23                 int ret;
  24
  25 +               os_memset(&settings, 0, sizeof(settings));
  26                 hostapd_cleanup_cca_params(bss);
  27                 bss->cca_color = r;
  28                 bss->cca_count = 10;