git.openwrt.org Git - openwrt/staging/blocktrron.git/blob

   1 From a08260154f88b0b97e3c8de6b3cdb7187e8c3d8a Mon Sep 17 00:00:00 2001
   2 From: Takashi Iwai <tiwai@suse.de>
   3 Date: Tue, 4 Sep 2018 17:58:41 +0200
   4 Subject: [PATCH] staging: bcm2835-audio: Drop unnecessary pcm indirect
   5  setup
   6
   7 commit 7318ec896f4856fae2bb013858e422fa078201e1 upstream.
   8
   9 The hw_queue_size of PCM indirect helper doesn't need to be set up if
  10 you use the whole given buffer size.  Drop the useless
  11 initialization, which just confuses readers.
  12
  13 Signed-off-by: Takashi Iwai <tiwai@suse.de>
  14 Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
  15 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  16 ---
  17  drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 1 -
  18  1 file changed, 1 deletion(-)
  19
  20 --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
  21 +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
  22 @@ -280,7 +280,6 @@ static int snd_bcm2835_pcm_ack(struct sn
  23         struct bcm2835_alsa_stream *alsa_stream = runtime->private_data;
  24         struct snd_pcm_indirect *pcm_indirect = &alsa_stream->pcm_indirect;
  25
  26 -       pcm_indirect->hw_queue_size = runtime->hw.buffer_bytes_max;
  27         return snd_pcm_indirect_playback_transfer(substream, pcm_indirect,
  28                                                   snd_bcm2835_pcm_transfer);
  29  }