1 From db56206e77d1a71c145669dc41d0ada496ea8e4f Mon Sep 17 00:00:00 2001
2 From: Dave Stevenson <dave.stevenson@raspberrypi.com>
3 Date: Wed, 28 Apr 2021 12:32:10 +0200
4 Subject: [PATCH] drm/vc4: Add debugfs node that dumps the vc5 gamma
7 This helps with debugging the conversion from a 256 point gamma LUT to
8 16 point PWL entries as used by the BCM2711.
10 Co-developed-by: Juerg Haefliger <juergh@canonical.com>
11 Signed-off-by: Juerg Haefliger <juergh@canonical.com>
12 Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
13 Signed-off-by: Maxime Ripard <maxime@cerno.tech>
15 drivers/gpu/drm/vc4/vc4_hvs.c | 81 +++++++++++++++++++++++++++++++++++
16 1 file changed, 81 insertions(+)
18 --- a/drivers/gpu/drm/vc4/vc4_hvs.c
19 +++ b/drivers/gpu/drm/vc4/vc4_hvs.c
20 @@ -134,6 +134,84 @@ static int vc4_hvs_debugfs_dlist(struct
24 +static int vc5_hvs_debugfs_gamma(struct seq_file *m, void *data)
26 + struct drm_info_node *node = m->private;
27 + struct drm_device *dev = node->minor->dev;
28 + struct vc4_dev *vc4 = to_vc4_dev(dev);
29 + struct drm_printer p = drm_seq_file_printer(m);
30 + unsigned int i, chan;
31 + u32 dispstat, dispbkgndx;
33 + for (chan = 0; chan < SCALER_CHANNELS_COUNT; chan++) {
35 + u32 offset = SCALER5_DSPGAMMA_START +
36 + chan * SCALER5_DSPGAMMA_CHAN_OFFSET;
38 + dispstat = VC4_GET_FIELD(HVS_READ(SCALER_DISPSTATX(chan)),
39 + SCALER_DISPSTATX_MODE);
40 + if (dispstat == SCALER_DISPSTATX_MODE_DISABLED ||
41 + dispstat == SCALER_DISPSTATX_MODE_EOF) {
42 + drm_printf(&p, "HVS channel %u: Channel disabled\n", chan);
46 + dispbkgndx = HVS_READ(SCALER_DISPBKGNDX(chan));
47 + if (!(dispbkgndx & SCALER_DISPBKGND_GAMMA)) {
48 + drm_printf(&p, "HVS channel %u: Gamma disabled\n", chan);
52 + drm_printf(&p, "HVS channel %u:\n", chan);
53 + drm_printf(&p, " red:\n");
54 + for (i = 0; i < SCALER5_DSPGAMMA_NUM_POINTS; i++, offset += 8) {
55 + x_c = HVS_READ(offset);
56 + grad = HVS_READ(offset + 4);
57 + drm_printf(&p, " %08x %08x - x %u, c %u, grad %u\n",
59 + VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_X),
60 + VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_C),
63 + drm_printf(&p, " green:\n");
64 + for (i = 0; i < SCALER5_DSPGAMMA_NUM_POINTS; i++, offset += 8) {
65 + x_c = HVS_READ(offset);
66 + grad = HVS_READ(offset + 4);
67 + drm_printf(&p, " %08x %08x - x %u, c %u, grad %u\n",
69 + VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_X),
70 + VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_C),
73 + drm_printf(&p, " blue:\n");
74 + for (i = 0; i < SCALER5_DSPGAMMA_NUM_POINTS; i++, offset += 8) {
75 + x_c = HVS_READ(offset);
76 + grad = HVS_READ(offset + 4);
77 + drm_printf(&p, " %08x %08x - x %u, c %u, grad %u\n",
79 + VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_X),
80 + VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_C),
84 + /* Alpha only valid on channel 2 */
88 + drm_printf(&p, " alpha:\n");
89 + for (i = 0; i < SCALER5_DSPGAMMA_NUM_POINTS; i++, offset += 8) {
90 + x_c = HVS_READ(offset);
91 + grad = HVS_READ(offset + 4);
92 + drm_printf(&p, " %08x %08x - x %u, c %u, grad %u\n",
94 + VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_X),
95 + VC4_GET_FIELD(x_c, SCALER5_DSPGAMMA_OFF_C),
102 /* The filter kernel is composed of dwords each containing 3 9-bit
103 * signed integers packed next to each other.
105 @@ -848,6 +926,9 @@ static int vc4_hvs_bind(struct device *d
107 vc4_debugfs_add_file(drm, "hvs_dlists", vc4_hvs_debugfs_dlist,
110 + vc4_debugfs_add_file(drm, "hvs_gamma", vc5_hvs_debugfs_gamma,